From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] da850evm: basic MII EMAC support
Date: Tue, 14 Sep 2010 09:00:15 -0400 [thread overview]
Message-ID: <201009140900.16694.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTi=8SjPakU9tRa6+9kuRrXMgHt2VVN+cVtE7dcJB@mail.gmail.com>
On Monday, September 13, 2010 08:55:47 Ben Gardiner wrote:
> On Sat, Sep 11, 2010 at 12:01 AM, Mike Frysinger wrote:
> > On Friday, September 10, 2010 16:10:16 Ben Gardiner wrote:
> >> The current da850evm support in u-boot/master [1] omits any use of
> >> the davinci EMAC. This patch adds basic support for the EMAC using
> >> the MII PHY found on the baseboard of the EVM. The MAC address is
> >> read from the environment variable 'ethadd'. Note that this is
> >> different from the da850evm support in the u-boot omapl1 tree
> >> where the MAC address is read from SPI flash [2].
> >>
> >> [1] http://git.denx.de/?p=u-boot.git
> >> [2] http://arago-project.org/git/projects/?p=u-boot-omapl1.git
> >
> > these URLs are useless. just drop them.
>
> Thanks for the feedback on these -- I have been wondering whether URL
> footnotes were desirable in commit messages. I put them there since I
> can remember that it is sometimes difficult to find the trees that are
> being referred to when you are a newcomer. Would SHA1's and/or git
> URLs be more acceptable? Or is the point that nothing before the '---'
> should have links?
it depends on the URLs. i dont think referring to the mainline git tree is
useful at all considering that's what they're using if they have this patch in
their tree. as for the omap1 reference, i'm not sure mentioning at all is
useful in the commit. presumably the tree in question will drop its code and
move to the mainline stuff one yours is merged. imo, that would make it a
"note" which goes below the "---".
if the URL is generally useful, then some people use a dedicated tag in the
"s-o-b" section such as "URL: xxx". this isnt exactly standardized.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/714c8fe8/attachment.pgp
next prev parent reply other threads:[~2010-09-14 13:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-10 20:10 [U-Boot] [PATCH] da850evm: basic MII EMAC support Ben Gardiner
2010-09-11 4:01 ` Mike Frysinger
2010-09-13 12:55 ` Ben Gardiner
2010-09-14 13:00 ` Mike Frysinger [this message]
2010-09-14 13:07 ` Ben Gardiner
2010-09-13 3:45 ` Ben Warren
2010-09-13 13:07 ` Ben Gardiner
2010-09-13 13:16 ` Ben Warren
2010-09-13 21:04 ` [U-Boot] [PATCH v2 0/2] da850evm " Ben Gardiner
2010-09-13 21:04 ` [U-Boot] [PATCH v2 1/2] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-14 8:37 ` Nick Thompson
2010-09-13 21:04 ` [U-Boot] [PATCH v2 2/2] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 17:16 ` [U-Boot] [PATCH v3 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 17:16 ` [U-Boot] [PATCH v3 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-22 17:16 ` [U-Boot] [PATCH v3 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-22 18:21 ` Mike Frysinger
2010-09-22 18:38 ` Ben Gardiner
2010-09-22 18:44 ` [U-Boot] [PATCH v4 0/2][NEXT] da850evm " Ben Gardiner
2010-09-22 18:44 ` [U-Boot] [PATCH v4 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23 9:03 ` Nick Thompson
2010-09-23 13:24 ` Ben Gardiner
2010-09-22 18:44 ` [U-Boot] [PATCH v4 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:33 ` [U-Boot] [PATCH v5 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:33 ` [U-Boot] [PATCH v5 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-09-23 13:49 ` Nick Thompson
2010-09-23 13:53 ` Ben Gardiner
2010-09-23 13:39 ` [U-Boot] [PATCH v5 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
2010-09-23 13:58 ` [U-Boot] [PATCH v6 0/2][NEXT] da850evm " Ben Gardiner
2010-09-23 13:58 ` [U-Boot] [PATCH v6 1/2][NEXT] davinci_emac: davinci_eth_set_mac_addr to ->write_hwaddr Ben Gardiner
2010-10-12 6:11 ` Ben Warren
2010-09-23 13:59 ` [U-Boot] [PATCH v6 2/2][NEXT] da850evm: basic MII EMAC support Ben Gardiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009140900.16694.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox