From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V4 1/2] MTD/SPI: introduce table driven probing
Date: Tue, 14 Sep 2010 10:53:19 -0400 [thread overview]
Message-ID: <201009141053.20919.vapier@gentoo.org> (raw)
In-Reply-To: <1284475809-12509-2-git-send-email-u-boot@emk-elektronik.de>
On Tuesday, September 14, 2010 10:50:08 Reinhard Meyer wrote:
> for JEDEC devices without and with extension bytes
> for non JEDEC devices
> Signed-off-by: Reinhard Meyer <u-boot@emk-elektronik.de>
needs to be a blank line before s-o-b tags and friends
> - * Licensed under the GPL-2 or later.
this is unnecessary noise. drop this hunk.
> + /*
> + * count the number of continuation bytes, but
> + * leave at least 3 bytes to the end of the buffer untouched
> + */
> + for (shift = 0, idp = idbuf;
> + shift < (sizeof(idbuf) - 3) && *idp == 0x7f;
> + shift++, idp++)
> + ;
is the offset of 3 necessary ? seems a little fragile ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/26e6e7d5/attachment.pgp
next prev parent reply other threads:[~2010-09-14 14:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-12 14:35 [U-Boot] Patches to support Ramtron SPI FRAMs Reinhard Meyer
2010-09-12 14:35 ` [U-Boot] [PATCH v3] MTD/SPI: introduce table driven probing Reinhard Meyer
2010-09-12 14:35 ` [U-Boot] [PATCH v3] MTD/SPI: add support for Ramtron FRAMs Reinhard Meyer
2010-09-12 14:42 ` [U-Boot] Patches to support Ramtron SPI FRAMs Wolfgang Denk
2010-09-12 15:38 ` Reinhard Meyer
2010-09-12 17:41 ` Wolfgang Denk
2010-09-12 18:51 ` Reinhard Meyer
2010-09-12 19:06 ` Wolfgang Denk
2010-09-12 19:16 ` Reinhard Meyer
2010-09-12 19:28 ` Wolfgang Denk
2010-09-12 19:26 ` Mike Frysinger
2010-09-12 19:36 ` Reinhard Meyer
2010-09-14 14:50 ` [U-Boot] [PATCH V4 0/2] " Reinhard Meyer
2010-09-14 14:50 ` [U-Boot] [PATCH V4 1/2] MTD/SPI: introduce table driven probing Reinhard Meyer
2010-09-14 14:50 ` [U-Boot] [PATCH V4 2/2] MTD/SPI: add support for Ramtron FRAMs Reinhard Meyer
2010-09-14 15:01 ` Mike Frysinger
2010-10-04 6:31 ` Reinhard Meyer
2010-10-04 7:17 ` Wolfgang Denk
2010-09-14 14:53 ` Mike Frysinger [this message]
2010-09-14 18:29 ` [U-Boot] [PATCH V4 1/2] MTD/SPI: introduce table driven probing Reinhard Meyer
2010-09-14 19:15 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009141053.20919.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox