From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Tue, 14 Sep 2010 10:53:19 -0400 Subject: [U-Boot] [PATCH V4 1/2] MTD/SPI: introduce table driven probing In-Reply-To: <1284475809-12509-2-git-send-email-u-boot@emk-elektronik.de> References: <1284302113-7939-1-git-send-email-u-boot@emk-elektronik.de> <1284475809-12509-1-git-send-email-u-boot@emk-elektronik.de> <1284475809-12509-2-git-send-email-u-boot@emk-elektronik.de> Message-ID: <201009141053.20919.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday, September 14, 2010 10:50:08 Reinhard Meyer wrote: > for JEDEC devices without and with extension bytes > for non JEDEC devices > Signed-off-by: Reinhard Meyer needs to be a blank line before s-o-b tags and friends > - * Licensed under the GPL-2 or later. this is unnecessary noise. drop this hunk. > + /* > + * count the number of continuation bytes, but > + * leave at least 3 bytes to the end of the buffer untouched > + */ > + for (shift = 0, idp = idbuf; > + shift < (sizeof(idbuf) - 3) && *idp == 0x7f; > + shift++, idp++) > + ; is the offset of 3 necessary ? seems a little fragile ... -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100914/26e6e7d5/attachment.pgp