From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: UART: Use NS16550 struct instead of offset macros
Date: Thu, 16 Sep 2010 14:16:34 +0200 [thread overview]
Message-ID: <201009161416.34827.sr@denx.de> (raw)
In-Reply-To: <m2pqwdzy37.fsf@ohwell.denx.de>
Hi Detlev,
On Thursday 16 September 2010 14:12:28 Detlev Zundel wrote:
> > This patch changes the PPC4xx UART driver to use the NS16550 struct
> > instead of macros for the register offsets.
>
> Dumb question - can't you reuse drivers/serial/ns16550.c completely?
> This would be even better. It worked for me on the vct boards,
> remember?
Yes, I remember. I'm "on the way" to using this common driver. But the PPC4xx
one currently has quite a lot of special handling cases, like this
SOFTWARE_FIFO stuff, which I first need to sort out.
But again, I'll try to move to the common driver soon.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-09-16 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-14 8:42 [U-Boot] [PATCH] ppc4xx: UART: Use NS16550 struct instead of offset macros Stefan Roese
2010-09-16 12:12 ` Detlev Zundel
2010-09-16 12:16 ` Stefan Roese [this message]
2010-09-16 12:27 ` Wolfgang Denk
2010-09-16 14:03 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009161416.34827.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox