From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 16 Sep 2010 14:16:34 +0200 Subject: [U-Boot] [PATCH] ppc4xx: UART: Use NS16550 struct instead of offset macros In-Reply-To: References: <1284453765-18443-1-git-send-email-sr@denx.de> Message-ID: <201009161416.34827.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Detlev, On Thursday 16 September 2010 14:12:28 Detlev Zundel wrote: > > This patch changes the PPC4xx UART driver to use the NS16550 struct > > instead of macros for the register offsets. > > Dumb question - can't you reuse drivers/serial/ns16550.c completely? > This would be even better. It worked for me on the vct boards, > remember? Yes, I remember. I'm "on the way" to using this common driver. But the PPC4xx one currently has quite a lot of special handling cases, like this SOFTWARE_FIFO stuff, which I first need to sort out. But again, I'll try to move to the common driver soon. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de