From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific
Date: Thu, 16 Sep 2010 14:18:54 +0200 [thread overview]
Message-ID: <201009161418.54408.sr@denx.de> (raw)
In-Reply-To: <m2tylpzyff.fsf@ohwell.denx.de>
Hi Detlev,
On Thursday 16 September 2010 14:05:08 Detlev Zundel wrote:
> > +++ b/arch/blackfin/cpu/cmd_gpio.c
> > @@ -10,7 +10,7 @@
> >
> > #include <command.h>
> >
> > #include <asm/blackfin.h>
> >
> > -#include <asm/gpio.h>
> > +#include <asm/ppc4xx-gpio.h>
>
> This really defeats the symlinking of the asm directory and using
> generic names. I believe you will break lots of non-4xx boards with
> this change. In other words, did you try a Blackfin build with this
> change? ;)
Ups. No, I totally missed this. Thanks for spotting. Will fix soon.
Please note that I plan to stay with this "asm/ppc4xx-gpio.h" name instead of
"asm/gpio.h", since there are many other PowerPC variants out there.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2010-09-16 12:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 8:34 [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific Stefan Roese
2010-09-16 12:05 ` Detlev Zundel
2010-09-16 12:18 ` Stefan Roese [this message]
2010-09-16 13:00 ` Detlev Zundel
2010-09-16 13:47 ` Stefan Roese
2010-09-22 20:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009161418.54408.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox