From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Thu, 16 Sep 2010 14:18:54 +0200
Subject: [U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since
	its ppc4xx specific
In-Reply-To: <m2tylpzyff.fsf@ohwell.denx.de>
References: <1284366840-31651-1-git-send-email-sr@denx.de>
	<m2tylpzyff.fsf@ohwell.denx.de>
Message-ID: <201009161418.54408.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Detlev,

On Thursday 16 September 2010 14:05:08 Detlev Zundel wrote:
> > +++ b/arch/blackfin/cpu/cmd_gpio.c
> > @@ -10,7 +10,7 @@
> > 
> >  #include <command.h>
> >  
> >  #include <asm/blackfin.h>
> > 
> > -#include <asm/gpio.h>
> > +#include <asm/ppc4xx-gpio.h>
> 
> This really defeats the symlinking of the asm directory and using
> generic names. I believe you will break lots of non-4xx boards with
> this change.  In other words, did you try a Blackfin build with this
> change? ;)

Ups. No, I totally missed this. Thanks for spotting. Will fix soon.

Please note that I plan to stay with this "asm/ppc4xx-gpio.h" name instead of 
"asm/gpio.h", since there are many other PowerPC variants out there.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de