[U-Boot] [PATCH 3/5] ppc4xx: Move gpio.h to ppc4xx-gpio.h since its ppc4xx specific

Detlev Zundel
2010-09-16T13:00:05Z

Hi Stefan,

> Ups. No, I totally missed this. Thanks for spotting. Will fix soon.

Ok.

> Please note that I plan to stay with this "asm/ppc4xx-gpio.h" name instead of
> "asm/gpio.h", since there are many other PowerPC variants out there.

I have to admit that I don't like this.

Hm, while you are doing something here, why not follow the Blackfin
example which I like a lot and move towards the Linux gpio interface
(see end of ./arch/blackfin/include/asm/gpio.h). It will be just lovely
to only generically request a gpio in common driver code.

Going down this route, code using gpios will only include "asm/gpio.h"
and use the generic functions. Doesn't that sound like a worthwhile
target? ;)

Cheers
Detlev

--
Infolge sklavischer "Kategoritis" werden die wissenschaftlichen unlogischen
und - wie wir sehen werden - oft sinnlosen Fragen wie "Wo wohnst du?", "Was
bist du?", "Welche Religion?", "Welche Rasse?", "Welche Nationalit?t?" alle-
samt heute f?r logische Fragen gehalten. -- Richard Buckminster Fuller
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de