From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] p1022ds: use weak CFI flash accessors when DIU is enabled
Date: Thu, 16 Sep 2010 23:29:35 +0200 [thread overview]
Message-ID: <20100916212935.C3BDC15242D@gemini.denx.de> (raw)
In-Reply-To: <4C928998.4040805@freescale.com>
Dear Timur Tabi,
In message <4C928998.4040805@freescale.com> you wrote:
>
> >> +/**
> >> + * set_mux_to_lbc - disable the DIU so that we can read/write to elbc
> >
> > Incorrect multiline comment format. Please check and fix globally.
>
> Can you be more specific? Is it the "**"?
Yes.
> > "#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS" / "#endif" arount the
> > #undef ?
>
> Why? CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS is only defined if CONFIG_VIDEO is
> defined. It's just one block of macros.
OK, if you like it that way. OTOH, the #ifdef would not hurt and keep
the logic in place in case you ever define
CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS for other reasons as well.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"...and the fully armed nuclear warheads, are, of course, merely a
courtesy detail."
prev parent reply other threads:[~2010-09-16 21:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 20:08 [U-Boot] [PATCH] p1022ds: use weak CFI flash accessors when DIU is enabled Timur Tabi
2010-09-16 21:13 ` Wolfgang Denk
2010-09-16 21:18 ` Timur Tabi
2010-09-16 21:29 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100916212935.C3BDC15242D@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox