From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH][v3] mpc8308_p1m: support for MPC8308 P1M board
Date: Sat, 18 Sep 2010 22:35:54 +0200 [thread overview]
Message-ID: <20100918203554.F2B4D157D71@gemini.denx.de> (raw)
In-Reply-To: <20100913201208.461501b3.kim.phillips@freescale.com>
Dear Kim Phillips,
In message <20100913201208.461501b3.kim.phillips@freescale.com> you wrote:
>
> > MAINTAINERS | 1 +
> > board/mpc8308_p1m/Makefile | 52 ++++
> > board/mpc8308_p1m/config.mk | 1 +
> > board/mpc8308_p1m/mpc8308_p1m.c | 122 +++++++++
> > board/mpc8308_p1m/sdram.c | 93 +++++++
> > boards.cfg | 1 +
> > include/configs/mpc8308_p1m.h | 548 +++++++++++++++++++++++++++++++++++++++
>
> missing MAKEALL entry.
Not needed any more since we pick this off from boards.cfg for
"simple" boards.
> > +++ b/board/mpc8308_p1m/config.mk
> > @@ -0,0 +1 @@
> > +TEXT_BASE = 0xFC000000
>
> ifndef TEXT_BASE
> TEXT_BASE = 0xFC000000
> endif
Why?
> > +int board_eth_init(bd_t *bis)
> > +{
> > + int rv, num_if = 0;
> > +
> > + /* Initialize TSECs first */
> > + if ((rv = cpu_eth_init(bis)) >= 0)
>
> no assignments in if statements.
Why?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Never ascribe to malice that which can adequately be explained by
stupidity.
next prev parent reply other threads:[~2010-09-18 20:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-25 14:00 [U-Boot] [PATCH] mpc8308_p1m: support for MPC8308 P1M board Ilya Yanok
2010-09-06 10:32 ` [U-Boot] [PATCH][v2] " Ilya Yanok
2010-09-07 21:47 ` Scott Wood
2010-09-08 21:36 ` [U-Boot] [PATCH][v3] " Ilya Yanok
2010-09-14 1:12 ` Kim Phillips
2010-09-14 20:40 ` [U-Boot] [PATCH 1/5] mpc83xx/pcie: make it compile with PCIE2 unconfigured Ilya Yanok
2010-09-14 20:40 ` [U-Boot] [PATCH 2/5] mpc83xx: add support for setting PCIE clocks Ilya Yanok
2010-09-14 20:40 ` [U-Boot] [PATCH 3/5] mpc8308: add SICR{L,H} fields definitions Ilya Yanok
2010-09-14 20:40 ` [U-Boot] [PATCH 4/5] MPC8308RDB: various clean ups Ilya Yanok
2010-09-14 20:40 ` [U-Boot] [PATCH 5/5] mpc8308_p1m: support for MPC8308 P1M board Ilya Yanok
2010-09-16 23:56 ` [U-Boot] [PATCH 4/5] MPC8308RDB: various clean ups Kim Phillips
2010-09-16 23:54 ` [U-Boot] [PATCH 1/5] mpc83xx/pcie: make it compile with PCIE2 unconfigured Kim Phillips
2010-09-17 21:35 ` Ilya Yanok
2010-09-17 21:41 ` Ilya Yanok
2010-09-22 21:02 ` Kim Phillips
2010-09-17 21:41 ` [U-Boot] [PATCH 2/5] mpc83xx: add support for setting PCIE clocks Ilya Yanok
2010-09-17 21:41 ` [U-Boot] [PATCH 3/5] mpc8308: add SICR{L,H} fields definitions Ilya Yanok
2010-09-17 21:41 ` [U-Boot] [PATCH 4/5] MPC8308RDB: various clean ups Ilya Yanok
2010-09-17 21:41 ` [U-Boot] [PATCH 5/5] mpc8308_p1m: support for MPC8308 P1M board Ilya Yanok
2010-09-18 20:35 ` Wolfgang Denk [this message]
2010-09-20 16:18 ` [U-Boot] [PATCH][v3] " Scott Wood
2010-09-20 16:42 ` Wolfgang Denk
2010-09-20 23:56 ` Kim Phillips
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100918203554.F2B4D157D71@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox