From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 20 Sep 2010 18:42:27 +0200 Subject: [U-Boot] [PATCH][v3] mpc8308_p1m: support for MPC8308 P1M board In-Reply-To: <20100920111852.0cc76594@udp111988uds.am.freescale.net> References: <20100907164758.53dd44b9@schlenkerla.am.freescale.net> <1283981819-20603-1-git-send-email-yanok@emcraft.com> <20100913201208.461501b3.kim.phillips@freescale.com> <20100918203554.F2B4D157D71@gemini.denx.de> <20100920111852.0cc76594@udp111988uds.am.freescale.net> Message-ID: <20100920164227.958FF157D71@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, In message <20100920111852.0cc76594@udp111988uds.am.freescale.net> you wrote: > > > ifndef TEXT_BASE > > > TEXT_BASE = 0xFC000000 > > > endif > > > > Why? > > It might have been already set to something else by nand_spl or > similar. No. There is no NAND on that board. > > > no assignments in if statements. > > > > Why? > > It could just as easily, and more readably, be written as: > > rv = cpu_eth_init(bis); > if (rv >= 0) > ... It depends whether you call that more readable. The UNIX code where I learned C was full of that, and I find it actually easier to read. > FWIW, Linux's checkpatch.pl looks for this and calls it an error, and > U-Boot says it follows Linux coding style. OK, that's an argument. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "The value of marriage is not that adults produce children, but that children produce adults." - Peter De Vries