public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Config: Add "board variant" column to boards.cfg
Date: Mon, 20 Sep 2010 20:02:38 +0200	[thread overview]
Message-ID: <20100920180238.467C0157D71@gemini.denx.de> (raw)
In-Reply-To: <1284947846-12811-2-git-send-email-marek.vasut@gmail.com>

Dear Marek Vasut,

In message <1284947846-12811-2-git-send-email-marek.vasut@gmail.com> you wrote:
> There are some boards where it's not currently possible to detect all board
> information at runtime, therefore I introduced a new column called "variant" to
> boards.cfg . If this field is set, CONFIG_fieldvalue is #define-d in config.h

Thanks for the start on this, but I would like to see a little more
genral approach here.

Passing a single option is IMO not enough. I posted a pretty complete
specification of the format I have in mind before:

http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/81138/focus=81332

Do you think you could adapt your implementation to more in line with
that?

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After a heated argument on some trivial matter Nancy [Astor]  .  .  .
shouted,  ``If  I were your wife I would put poison in your coffee!''
Whereupon Winston Churchill with equal heat and  sincerity  answered,
``And if I were your husband I would drink it.''

  reply	other threads:[~2010-09-20 18:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-20  1:57 [U-Boot] [PATCH 1/2] USB: Make non-bulk delay longer in OHCI Marek Vasut
2010-09-20  1:57 ` [U-Boot] [PATCH 2/2] Config: Add "board variant" column to boards.cfg Marek Vasut
2010-09-20 18:02   ` Wolfgang Denk [this message]
2010-10-03 23:36 ` [U-Boot] [PATCH 1/2] USB: Make non-bulk delay longer in OHCI Marek Vasut
2010-10-04  4:43   ` Wolfgang Denk
2010-10-04 14:02     ` Marek Vasut
2010-10-04 16:42       ` Wolfgang Denk
2010-10-05 11:48         ` Detlev Zundel
2010-10-09  7:27 ` Remy Bohmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100920180238.467C0157D71@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox