From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 20 Sep 2010 20:02:38 +0200 Subject: [U-Boot] [PATCH 2/2] Config: Add "board variant" column to boards.cfg In-Reply-To: <1284947846-12811-2-git-send-email-marek.vasut@gmail.com> References: <1284947846-12811-1-git-send-email-marek.vasut@gmail.com> <1284947846-12811-2-git-send-email-marek.vasut@gmail.com> Message-ID: <20100920180238.467C0157D71@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Marek Vasut, In message <1284947846-12811-2-git-send-email-marek.vasut@gmail.com> you wrote: > There are some boards where it's not currently possible to detect all board > information at runtime, therefore I introduced a new column called "variant" to > boards.cfg . If this field is set, CONFIG_fieldvalue is #define-d in config.h Thanks for the start on this, but I would like to see a little more genral approach here. Passing a single option is IMO not enough. I posted a pretty complete specification of the format I have in mind before: http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/81138/focus=81332 Do you think you could adapt your implementation to more in line with that? Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de After a heated argument on some trivial matter Nancy [Astor] . . . shouted, ``If I were your wife I would put poison in your coffee!'' Whereupon Winston Churchill with equal heat and sincerity answered, ``And if I were your husband I would drink it.''