public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3] NET: add ENC28J60 driver using SPI framework
Date: Mon, 20 Sep 2010 19:44:35 -0400	[thread overview]
Message-ID: <201009201944.36403.vapier@gentoo.org> (raw)
In-Reply-To: <201009201744.39170.vapier@gentoo.org>

On Monday, September 20, 2010 17:44:38 Mike Frysinger wrote:
> finally got around to testing this.  seems like the init needs some work. 
> if i power on the system (cold boot), boot Linux over the on-chip mac, and
> let Linux program the enc part, it works fine under Linux.  then i do a
> software reset back into u-boot, it can use the enc fine too.
> 
> but if i cold boot u-boot and try to use the enc part, i get:
> 	timeout waiting for CLKRDY
> enabling DEBUG doesnt show any additional output though.

comparing the linux and u-boot drivers leads me to this fix:

--- a/drivers/net/enc28j60.c
+++ b/drivers/net/enc28j60.c
@@ -632,6 +632,8 @@ static int enc_clock_wait(enc_dev_t *enc)
 {
 	uint64_t etime;
 
+	enc_bclr(enc, CTL_REG_ECON2, ENC_ECON2_PWRSV);
+
  	/* one second timeout */
 	etime = get_ticks() + get_tbclk();
 

i dont know if Ben wants to squash this change in his next tree, or do a patch 
on top of it ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100920/c32c16a4/attachment.pgp 

  reply	other threads:[~2010-09-20 23:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-12 14:23 [U-Boot] [PATCH v3] NET: add ENC28J60 driver using SPI framework Reinhard Meyer
2010-09-13  4:21 ` Ben Warren
2010-09-20 21:44 ` Mike Frysinger
2010-09-20 23:44   ` Mike Frysinger [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-09-21  5:21 Reinhard Meyer
2010-09-21  5:52 ` Mike Frysinger
2010-09-21  6:12   ` Reinhard Meyer
2010-09-21 13:40   ` Ben Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201009201944.36403.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox