From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Cleanup of PVR detection code in cpu.c
Date: Wed, 22 Sep 2010 10:52:52 +0200 [thread overview]
Message-ID: <201009221052.52763.sr@denx.de> (raw)
In-Reply-To: <1284035711-16502-1-git-send-email-sr@denx.de>
On Thursday 09 September 2010 14:35:11 Stefan Roese wrote:
> This patch cleans the PVR detection code in check_cpu() up a bit.
> Basically the strings are better seperated, resulting in an easier
> to understand and maintain code version.
>
> The #ifdef's couldn't be removed easily because of two reasons:
>
> - Some SoC revisions have the same PVR, so need a way to differentiate
> between those two SoC's.
> - In some case statements registers only available in this SoC variant
> are referenced.
>
> Instead I moved the CONFIG_440 #ifdef a bit, so that 405 platforms don't
> add this 440 detection code and vice versa. Resulting in this U-Boot
> image size change:
>
> 405EX (Kilauea): 408 bytes less
> 440EPx (Sequoia): 604 bytes less
> 460EX (Canyonlands): 564 bytes less
Applied to u-boot-ppc4xx/next. Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
prev parent reply other threads:[~2010-09-22 8:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-09 12:35 [U-Boot] [PATCH] ppc4xx: Cleanup of PVR detection code in cpu.c Stefan Roese
2010-09-22 8:52 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201009221052.52763.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox