From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anatolij Gustschin <agust@denx.de>
Date: Thu, 23 Sep 2010 18:38:43 +0200
Subject: [U-Boot] [PATCH] fsl_diu_fb: further refactoring of FLS DIU code
In-Reply-To: <4C9B8111.9050509@freescale.com>
References: <1285173970-21875-1-git-send-email-timur@freescale.com>
	<1285199836-5640-1-git-send-email-agust@denx.de>
	<4C9B8111.9050509@freescale.com>
Message-ID: <20100923183843.14d6c317@wker>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Thu, 23 Sep 2010 11:32:17 -0500
Timur Tabi <timur@freescale.com> wrote:

> Anatolij Gustschin wrote:
> > This is the first patch version for testing on HW I do not
> > have (mpc8610hpcd, p1022ds). Tested on pdm360ng board.
> > 
> > The patch will be modified to fix board config files as
> > needed in the final version. We probably should also move
> > fsl_diu_fb.c file to 'drivers/video'.
> 
> This works, except the default should be CONFIG_VIDEO is undefined.  It's
> unlikely the customer will have a monitor connected to the DVI port.

Ok, thanks.

> > +++ b/include/configs/MPC8610HPCD.h
> > @@ -22,7 +22,9 @@
> >  #define CONFIG_FSL_DIU_FB	1	/* FSL DIU */
> >  
> >  /* video */
> > -#undef CONFIG_VIDEO
> > +#ifdef CONFIG_FSL_DIU_FB
> > +#define CONFIG_VIDEO
> > +#endif
> 
> leave this undefined, and ...

Okay.

...
> > +++ b/include/configs/P1022DS.h
> > @@ -178,7 +178,7 @@
> >  #define CONFIG_SYS_PROMPT_HUSH_PS2 "> "
> >  
> >  /* Video */
> > -#undef CONFIG_FSL_DIU_FB
> > +#define CONFIG_FSL_DIU_FB
> 
> don't make this change.

Yes. I enabled it for your test and will remove it.

Thanks,
Anatolij