From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 28 Sep 2010 19:44:50 +0200 Subject: [U-Boot] [PATCH] mpc5xxx_fec: add call to reset_phy() after PHY initialization In-Reply-To: <20100913093325.A8A8415242D@gemini.denx.de> References: <1282208946-18823-1-git-send-email-yanok@emcraft.com> <20100913093325.A8A8415242D@gemini.denx.de> Message-ID: <20100928174450.DBAFFD52190@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ben, ping again... In message <20100913093325.A8A8415242D@gemini.denx.de> I wrote: > Dear Ben, > > In message <1282208946-18823-1-git-send-email-yanok@emcraft.com> Ilya Yanok wrote: > > Some boards need their board-specific PHY quirks to be called > > to PHY to work normally. As mpc5xxx_fec driver uses on demand > > PHY initialization and can even reinit PHY during normal operation > > we can't count on reset_phy() call from arch//lib/board.c > > (it is most likely called _before_ we init the PHY from the > > driver) so we need to add call to reset_phy() directly in the > > driver. > > > > Cc: Ben Warren > > Signed-off-by: Ilya Yanok > > --- > > drivers/net/mpc5xxx_fec.c | 7 +++++++ > > 1 files changed, 7 insertions(+), 0 deletions(-) > > Do you have any comments? Please comment how to go on - this is a real problem that needs to be fixed one way or another. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is more rational to sacrifice one life than six. -- Spock, "The Galileo Seven", stardate 2822.3