From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Tue, 28 Sep 2010 20:50:27 +0200
Subject: [U-Boot] [PATCH V2 1/7] Expand POST memory test to support
	arch-depended implementation.
In-Reply-To: <1285696512.30239.14.camel@oslab-l1>
References: <1285691891-32700-1-git-send-email-yorksun@freescale.com>
	<20100928173130.CDDF9D52190@gemini.denx.de>
	<1285696512.30239.14.camel@oslab-l1>
Message-ID: <20100928185027.40AD3D52190@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear York Sun,

In message <1285696512.30239.14.camel@oslab-l1> you wrote:
> On Tue, 2010-09-28 at 19:31 +0200, Wolfgang Denk wrote:
> 
> > > -int memory_post_test (int flags)
> > > +__attribute__((weak))
> > > +int arch_memory_test_prepare(u32 *vstart, u32 *size, phys_addr_t *phys_offset)
> > 
> > phys_offset is unused here. Drop it?
> > 
> 
> The phys_offset is not used by _this_ weak function but it is used by
> another function implemented in the third patch. Is it OK to leave the
> unused phys_offset here?

What does the compiler say?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
He'd heard her use that sweet, innocent  tone  of  voice  before.  It
meant that, pretty soon, there was going to be trouble.
                                        - Terry Pratchett, _Truckers_