From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc83xx: fix 837x MDS PCI HOST build
Date: Thu, 30 Sep 2010 14:15:17 -0500 [thread overview]
Message-ID: <20100930141517.92dacbb7.kim.phillips@freescale.com> (raw)
In-Reply-To: <1285873751.28947.19984.camel@petert>
On Thu, 30 Sep 2010 14:09:11 -0500
Peter Tyser <ptyser@xes-inc.com> wrote:
> On Thu, 2010-09-30 at 13:40 -0500, Kim Phillips wrote:
> > commit 6aa3d3bfaa986f1aff5e21a9b9f68d087715b1a9
> > "83xx: Remove warmboot parameter from PCI init functions" missed
> > one mpc83xx_pcie_init callsite, causing this build error:
> >
> > Configuring for MPC837XEMDS_HOST board...
> > pci.c: In function 'pci_init_board':
> > pci.c:141: error: too many arguments to function 'mpc83xx_pcie_init'
> >
> > this patch extends the commit to include that callsite.
>
> Thanks for catching that. Should the MPC837XEMDS MAKEALL target be
> changed to MPC837XEMDS_HOST to include coverage of its PCI code? I
either that or the makeall code that uses boards.cfg could be extended
to do certain board build variants...needs looking into.
> tried running ./MAKEALL 83xx prior to submitting the offending change,
> but didn't catch this issue. Same for the MPC832XEMDS?
the 832x mds looks ok to me.
Kim
next prev parent reply other threads:[~2010-09-30 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-30 18:40 [U-Boot] [PATCH] mpc83xx: fix 837x MDS PCI HOST build Kim Phillips
2010-09-30 19:09 ` Peter Tyser
2010-09-30 19:15 ` Kim Phillips [this message]
2010-09-30 19:28 ` Wolfgang Denk
2010-10-18 19:55 ` Wolfgang Denk
2010-10-11 23:45 ` Kim Phillips
2010-10-18 19:53 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100930141517.92dacbb7.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox