From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate
Date: Fri, 01 Oct 2010 09:57:49 +0200 [thread overview]
Message-ID: <20101001075749.B131C153A7E@gemini.denx.de> (raw)
In-Reply-To: <87sk0q1mnf.wl%ysato@users.sourceforge.jp>
Dear Yoshinori Sato,
In message <87sk0q1mnf.wl%ysato@users.sourceforge.jp> you wrote:
>
> It changes reduce bss usage.
... and increases the load on the malloc arean.
> Ymodem receive buffer dinamic allocation.
As far as I can see we increase the code size, and shift a fixed sized
buffer from bss to the maloc arene.
I don't consider this an improvement, but I may be overlooking
something.
Which advantages do you see with the changed code?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If the facts don't fit the theory, change the facts.
-- Albert Einstein
next prev parent reply other threads:[~2010-10-01 7:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 5:56 [U-Boot] [PATCH] xyzModem.c Packet buffer dynamic allocate Yoshinori Sato
2010-10-01 7:57 ` Wolfgang Denk [this message]
2010-10-01 15:02 ` Yoshinori Sato
2010-10-01 19:39 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101001075749.B131C153A7E@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox