public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] OneNAND: Move largepage_memorybased
Date: Mon, 4 Oct 2010 02:23:14 +0200	[thread overview]
Message-ID: <201010040223.14790.marek.vasut@gmail.com> (raw)
In-Reply-To: <1286040839-3215-1-git-send-email-marek.vasut@gmail.com>

Dne So 2. ??jna 2010 19:33:56 Marek Vasut napsal(a):
> This moves "struct nand_bbt_descr largepage_memorybased" into
> "onenand_default_bbt" as that's the only place where this is used.
> 
> This also removes an entry from .data section. (For me, this section
> disappears after relocation).

Scott, can you please check this and the other three patches? Thanks
> 
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  drivers/mtd/onenand/onenand_bbt.c |   25 ++++++++++++-------------
>  1 files changed, 12 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/mtd/onenand/onenand_bbt.c
> b/drivers/mtd/onenand/onenand_bbt.c index 1354877..c5d3905 100644
> --- a/drivers/mtd/onenand/onenand_bbt.c
> +++ b/drivers/mtd/onenand/onenand_bbt.c
> @@ -227,19 +227,6 @@ int onenand_scan_bbt(struct mtd_info *mtd, struct
> nand_bbt_descr *bd) return ret;
>  }
> 
> -/*
> - * Define some generic bad / good block scan pattern which are used
> - * while scanning a device for factory marked good / bad blocks.
> - */
> -static uint8_t scan_ff_pattern[] = { 0xff, 0xff };
> -
> -static struct nand_bbt_descr largepage_memorybased = {
> -	.options = 0,
> -	.offs = 0,
> -	.len = 2,
> -	.pattern = scan_ff_pattern,
> -};
> -
>  /**
>   * onenand_default_bbt - [OneNAND Interface] Select a default bad block
> table for the device * @param mtd		MTD device structure
> @@ -252,6 +239,18 @@ int onenand_default_bbt(struct mtd_info *mtd)
>  	struct onenand_chip *this = mtd->priv;
>  	struct bbm_info *bbm;
> 
> +	/*
> +	 * Define some generic bad / good block scan pattern which are used
> +	 * while scanning a device for factory marked good / bad blocks.
> +	 */
> +	uint8_t scan_ff_pattern[] = { 0xff, 0xff };
> +	struct nand_bbt_descr largepage_memorybased = {
> +		.options = 0,
> +		.offs = 0,
> +		.len = 2,
> +		.pattern = scan_ff_pattern,
> +	};
> +
>  	this->bbm = malloc(sizeof(struct bbm_info));
>  	if (!this->bbm)
>  		return -ENOMEM;

  parent reply	other threads:[~2010-10-04  0:23 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-02 17:33 [U-Boot] [PATCH 1/4] OneNAND: Move largepage_memorybased Marek Vasut
2010-10-02 17:33 ` [U-Boot] [PATCH 2/4] OneNAND: Fixup command table on reloc Marek Vasut
2010-10-02 18:28   ` Minkyu Kang
2010-10-02 18:59     ` Marek Vasut
2010-10-02 19:31       ` Minkyu Kang
2010-10-03 18:21       ` Wolfgang Denk
2010-10-03 19:24         ` Marek Vasut
2010-10-03 21:16           ` Wolfgang Denk
2010-10-03 11:19   ` Sergei Shtylyov
2010-10-03 14:25     ` Marek Vasut
2010-10-03 18:39       ` Wolfgang Denk
2010-10-02 17:33 ` [U-Boot] [PATCH 3/4] OneNAND: Introduce CONFIG_SYS_IPL_LOAD_ADDR Marek Vasut
2010-10-03  6:40   ` Kyungmin Park
2010-10-03 14:25     ` Marek Vasut
2010-10-02 17:33 ` [U-Boot] [PATCH 4/4] OneNAND: Use generic_onenand_read_page in IPL Marek Vasut
2010-10-03  6:40   ` Kyungmin Park
2010-10-03 14:27     ` Marek Vasut
2010-10-03 23:33       ` Marek Vasut
2010-10-03 23:45         ` Kyungmin Park
2010-10-04  0:24           ` Marek Vasut
2010-10-04  6:05             ` Wolfgang Denk
2010-10-14 21:15           ` Marek Vasut
2010-10-04 18:09   ` Scott Wood
2010-10-04  0:23 ` Marek Vasut [this message]
2010-10-04 17:59 ` [U-Boot] [PATCH 1/4] OneNAND: Move largepage_memorybased Scott Wood
2010-10-04 21:15   ` Marek Vasut
2010-10-04 21:18     ` Scott Wood
2010-10-04 22:31       ` Marek Vasut
2010-10-05  2:05         ` Kyungmin Park
2010-10-05  2:36           ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201010040223.14790.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox