[U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test

[U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test

[Stefan Roese]

From: Sascha Laue <sascha.laue@liebherr.com>

Needed to ensure that this UART POST is always excecuted.

Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
Signed-off-by: Stefan Roese <sr@denx.de>
---
 post/tests.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/post/tests.c b/post/tests.c
index a4066f9..02bf538 100644
--- a/post/tests.c
+++ b/post/tests.c
@@ -169,7 +169,7 @@ struct post_test post_list[] =
 	"UART test",
 	"uart",
 	"This test verifies the UART operation.",
-	POST_RAM | POST_SLOWTEST | POST_MANUAL,
+	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,
 	&uart_post_test,
 	NULL,
 	NULL,
-- 
1.7.3

[U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test

[Wolfgang Denk]

Dear Stefan Roese,

In message <1285773253-29490-1-git-send-email-sr@denx.de> you wrote:
> From: Sascha Laue <sascha.laue@liebherr.com>
> 
> Needed to ensure that this UART POST is always excecuted.
> 
> Signed-off-by: Sascha Laue <sascha.laue@liebherr.com>
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  post/tests.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/post/tests.c b/post/tests.c
> index a4066f9..02bf538 100644
> --- a/post/tests.c
> +++ b/post/tests.c
> @@ -169,7 +169,7 @@ struct post_test post_list[] =
>  	"UART test",
>  	"uart",
>  	"This test verifies the UART operation.",
> -	POST_RAM | POST_SLOWTEST | POST_MANUAL,
> +	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,

Instead of globally enforcing this for all boards, can this not be
done in a board specific way?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain off-line, please wait.

[U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test

[Stefan Roese]

Hi Wolfgang,

On Wednesday 06 October 2010 23:04:36 Wolfgang Denk wrote:
> > diff --git a/post/tests.c b/post/tests.c
> > index a4066f9..02bf538 100644
> > --- a/post/tests.c
> > +++ b/post/tests.c
> > @@ -169,7 +169,7 @@ struct post_test post_list[] =
> > 
> >  	"UART test",
> >  	"uart",
> >  	"This test verifies the UART operation.",
> > 
> > -	POST_RAM | POST_SLOWTEST | POST_MANUAL,
> > +	POST_RAM | POST_SLOWTEST | POST_ALWAYS | POST_MANUAL,
> 
> Instead of globally enforcing this for all boards, can this not be
> done in a board specific way?

Yes, can be done. I could make it board specific as already done for other 
POST tests:

#if CONFIG_POST & CONFIG_SYS_POST_UART
#if defined(CONFIG_POST_UART)
	CONFIG_POST_UART,
#else
    {
	"UART test",
	"uart",
	"This test verifies the UART operation.",
	POST_RAM | POST_SLOWTEST | POST_MANUAL,
	&uart_post_test,
	NULL,
	NULL,
	CONFIG_SYS_POST_UART
    },
#endif

So the board config header could provide a board specific test by defining 
CONFIG_POST_UART. Is this what you would prefer?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

[U-Boot] [PATCH] POST: Add POST_ALWAYS to UART POST test

[Wolfgang Denk]

Dear Stefan Roese,

In message <201010070850.00126.sr@denx.de> you wrote:
> 
> > Instead of globally enforcing this for all boards, can this not be
> > done in a board specific way?
> 
> Yes, can be done. I could make it board specific as already done for other 
> POST tests:
...
> So the board config header could provide a board specific test by defining 
> CONFIG_POST_UART. Is this what you would prefer?

Yes, indeed.  Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer  to  those  who
are  concerned  with  the fate of the project: "Don't worry about the
mule. Just load the wagon."         - Mike Dennison's hillbilly uncle