From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv2 2/3] OMAP3: SDRC: Introduce Numonyx DDR type
Date: Sun, 10 Oct 2010 12:13:11 +0200 [thread overview]
Message-ID: <20101010101311.61AB1544@gemini.denx.de> (raw)
In-Reply-To: <AANLkTin9UM8UC7saYB9di0UB3D04r+hZuK5Z-xXJmmSn@mail.gmail.com>
Dear =?UTF-8?Q?Enric_Balletb=C3=B2_i_Serra?=,
In message <AANLkTin9UM8UC7saYB9di0UB3D04r+hZuK5Z-xXJmmSn@mail.gmail.com> you wrote:
>
> >> @@ -136,6 +174,10 @@ enum {
> >> #define V_ACTIMA_165 MICRON_V_ACTIMA_165
> >> #define V_ACTIMB_165 MICRON_V_ACTIMB_165
> >> #endif
> >> +#ifdef CONFIG_OMAP3_NUMONYX_DDR
> >> +#define V_ACTIMA_165 NUMONYX_V_ACTIMA_165
> >> +#define V_ACTIMB_165 NUMONYX_V_ACTIMB_165
> >> +#endif
> >
> > You are using exactly the same settings as for the
> > #ifdef CONFIG_OMAP3_MICRON_DDR above. Why do you repeat the lines
> > then? Rather use a "#if defined(...) || defined(...)"
>
> I'm not agree the timmings are not the same, here a list of differences
Oops. I misread this. Sorry for the confusion.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Anyone attempting to generate random numbers by deterministic means
is, of course, living in a state of sin." - John Von Neumann
next prev parent reply other threads:[~2010-10-10 10:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-10 8:34 [U-Boot] [PATCHv2 0/3] Add support for the IGEP v2 board Enric Balletbo i Serra
2010-10-10 8:34 ` [U-Boot] [PATCHv2 1/3] mtd: OneNAND: add support for OneNAND manufactured by Numonyx Enric Balletbo i Serra
2010-10-10 9:14 ` Wolfgang Denk
2010-10-10 8:34 ` [U-Boot] [PATCHv2 2/3] OMAP3: SDRC: Introduce Numonyx DDR type Enric Balletbo i Serra
2010-10-10 9:17 ` Wolfgang Denk
2010-10-10 9:36 ` Enric Balletbò i Serra
2010-10-10 10:13 ` Wolfgang Denk [this message]
2010-10-10 8:34 ` [U-Boot] [PATCHv2 3/3] OMAP3: Add support for the IGEP v2 board Enric Balletbo i Serra
2010-10-10 9:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101010101311.61AB1544@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox