[U-Boot] [PATCH v2 1/5] Build: Add "board options" column to boards.cfg

Reinhard Meyer
2010-10-17T00:13:52Z

Dear Wolfgang Denk,

> In case of simple options like '256M_U_BOOT', these expand to
> "#define CONFIG_MK_256M_U_BOOT 1" in config.h . In case of
> assignments like 'RAM=8192', these expand to "#define CONFIG_MK_RAM
> 8192" in config.h .

Umm, what about:

> Out of principle: please omit the "1" in all such cases unless you
> really want to pass or test for such a numeric value anywhere. As far
> as I can tell all relevant code uses only "#ifdef" or "defined(...)",
> so not to confuse people better omit the irrelevant value.

Your own words ;)

If someone really needs the "1", they can always write "=1" in boards.cfg.

Best Regards,
Reinhard