From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/6] ARM: add flat device tree support
Date: Wed, 13 Oct 2010 07:52:00 +0200 [thread overview]
Message-ID: <20101013055200.CAA8A151F66@gemini.denx.de> (raw)
In-Reply-To: <AANLkTikYU9LtSCHLUP-6-=vd5WPWpnyVkHkZnW23zqc5@mail.gmail.com>
Dear John Rigby,
In message <AANLkTikYU9LtSCHLUP-6-=vd5WPWpnyVkHkZnW23zqc5@mail.gmail.com> you wrote:
>
> >> index 4e8dfd7..d85a396 100644
> >> --- a/arch/arm/include/asm/config.h
> >> +++ b/arch/arm/include/asm/config.h
> >> @@ -25,4 +25,6 @@
> >> /* Relocation to SDRAM works on all ARM boards */
> >> #define CONFIG_RELOC_FIXUP_WORKS
> >> #endif
> >> +#define CONFIG_LMB
> >> +#define CONFIG_BOOT_RAMDISK_HIGH
> >> #endif
> >
> > These should be CONFIG_SYS_ instead.
> These are not new. Do you want me to submit a patch changing all
> existing instances to CONFIG_SYS_*?
Not new? I must be missing something then. I cannot find any reference
to CONFIG_BOOT_RAMDISK_HIGH anywhere in the current code.
CONFIG_LMB is indeed not new, but a misnomer that should by fixed.
Also, an explanation should be added to the README. [I am aware that
this is not a fault of your patch.]
CONFIG_RELOC_FIXUP_WORKS is also a misnomer now, and undocumented :-(
> > On which systems / architectures has this been tested?
Please make sure to proovide such information, it _is_ important.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Celestial navigation is based on the premise that the Earth is the
center of the universe. The premise is wrong, but the navigation
works. An incorrect model can be a useful tool. - Kelvin Throop III
next prev parent reply other threads:[~2010-10-13 5:52 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-29 15:48 [U-Boot] [PATCH v2 0/6] Add ARM flat device tree support John Rigby
2010-09-29 15:48 ` [U-Boot] [PATCH v2 1/6] fdt_relocate: fix fdt size and endian bugs John Rigby
2010-10-12 21:20 ` Wolfgang Denk
2010-10-12 21:57 ` John Rigby
2010-10-13 5:55 ` Wolfgang Denk
2010-09-29 15:48 ` [U-Boot] [PATCH v2 2/6] FDT: Add fixup support for multiple banks of memory John Rigby
2010-10-12 21:21 ` Wolfgang Denk
2010-09-29 15:48 ` [U-Boot] [PATCH v2 3/6] FDT: only call boot_get_fdt from generic code John Rigby
2010-10-12 21:24 ` Wolfgang Denk
2010-10-12 21:33 ` John Rigby
2010-10-12 21:40 ` Wolfgang Denk
2010-09-29 15:48 ` [U-Boot] [PATCH v2 4/6] boot: change some arch ifdefs to feature ifdefs John Rigby
2010-10-12 21:27 ` Wolfgang Denk
2010-10-12 21:41 ` John Rigby
2010-09-29 15:48 ` [U-Boot] [PATCH v2 5/6] ARM: add flat device tree support John Rigby
2010-10-07 14:56 ` John Rigby
2010-10-12 21:29 ` Wolfgang Denk
2010-10-12 21:39 ` John Rigby
2010-10-13 5:52 ` Wolfgang Denk [this message]
2010-09-29 15:48 ` [U-Boot] [PATCH v2 6/6] ARM: enable device tree for beagle John Rigby
2010-10-07 16:11 ` [U-Boot] [PATCH v2 0/6] Add ARM flat device tree support John Rigby
2010-10-07 16:14 ` John Rigby
2010-10-07 17:45 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 0/7] " John Rigby
2010-10-13 20:41 ` Wolfgang Denk
2010-10-13 21:20 ` John Rigby
2010-10-17 1:59 ` Gerald Van Baren
2010-10-13 19:57 ` [U-Boot] [PATCH v3 1/7] common/image.c fix length calculation in boot_relocate_fdt John Rigby
2010-10-18 20:50 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 2/7] common/image.c remove extra calls to be32_to_cpu in boot_get_fdt John Rigby
2010-10-18 20:50 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 3/7] FDT: Add fixup support for multiple banks of memory John Rigby
2010-10-18 20:51 ` Wolfgang Denk
2010-10-20 7:02 ` [U-Boot] [PATCH] common/fdt_support.c: Fix compile warnings Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 4/7] FDT: only call boot_get_fdt from generic code John Rigby
2010-10-14 3:07 ` Michal Simek
2010-10-18 6:38 ` Thomas Chou
2010-10-18 20:52 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 5/7] boot: change some arch ifdefs to feature ifdefs John Rigby
2010-10-18 20:53 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 6/7] ARM: add flat device tree support John Rigby
2010-10-18 20:54 ` Wolfgang Denk
2010-10-13 19:57 ` [U-Boot] [PATCH v3 7/7] ARM: enable device tree for beagle John Rigby
2010-10-18 20:54 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013055200.CAA8A151F66@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox