From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 13 Oct 2010 09:30:58 +0200
Subject: [U-Boot] [PATCH] ppc4xx: Add CATCenter Io 405EP board support
In-Reply-To: <48D3D52125C49B43AE880038E2E5314BB5BDE9@SRV101.gdsys.de>
References: <1286890387-11491-1-git-send-email-eibach@gdsys.de>
	<201010121741.49236.sr@denx.de>
	<48D3D52125C49B43AE880038E2E5314BB5BDE9@SRV101.gdsys.de>
Message-ID: <201010130930.58438.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Dirk,

On Wednesday 13 October 2010 09:25:33 Eibach, Dirk wrote:
> > > +#define MDIO_ACTIVE	out32(GPIO0_TCR, in32(GPIO0_TCR) |
> > > CONFIG_SYS_MDIO_PIN)
> > 
> > Use out_be32() accessors here and below.
> 
> Just being curious: why?

Because of the included memory barriers in the in/out_be32() functions. You 
might run into problems when using the "plain" in/out32() function requiring 
extra "sync" instructions.

> Has in32() also to be replaced?

Yes, of course.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de