From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Wed, 13 Oct 2010 09:43:47 -0400 Subject: [U-Boot] [PATCH 2/2] sf: ramtron: new spi fram driver In-Reply-To: <4CB56374.7040901@emk-elektronik.de> References: <1286290600-18988-1-git-send-email-u-boot@emk-elektronik.de> <1286785742-1772-2-git-send-email-vapier@gentoo.org> <4CB56374.7040901@emk-elektronik.de> Message-ID: <201010130943.48972.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wednesday, October 13, 2010 03:44:52 Reinhard Meyer wrote: > Mike Frysinger wrote: > > +#ifdef CONFIG_SPI_FRAM_RAMTRON > > + { 6, 0xc2, spi_fram_probe_ramtron, }, > > +# undef IDCODE_CONT_LEN > > +# define IDCODE_CONT_LEN 6 > > +#endif > > That code should only increase the IDCODE_CONT_LEN, not > set it to a value. It might have been set larger by a > previous #ifdef. i noticed that, but this isnt any different from your original patch, and i figured we could delay worrying about that when someone else proposed something that wanted to change the size. whichever you want. > Even "nicer" and maybe better understandable could be: > > +#ifdef CONFIG_SPI_FRAM_RAMTRON > +# define RAMTRON_CONT_LEN 6 i'd prefer the first version. i dont think this gains us much. > I cannot test all this right now. Maybe you put just the probing > part (1/2) into mainline, once all my local ahead-of-MASTER and posted > patches are in mainline, I'll do a big rebase and fix session here and > post a new ramtron patch. OK -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20101013/7fae5e17/attachment.pgp