From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Add CATCenter IoCon 405EP board support
Date: Wed, 13 Oct 2010 16:46:47 +0200 [thread overview]
Message-ID: <20101013144647.D14DD1365CF@gemini.denx.de> (raw)
In-Reply-To: <1286971128-12128-1-git-send-email-eibach@gdsys.de>
Dear Dirk Eibach,
In message <1286971128-12128-1-git-send-email-eibach@gdsys.de> you wrote:
> Board support for the Guntermann & Drunck IoCon.
>
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
> MAINTAINERS | 1 +
> MAKEALL | 1 +
> board/gdsys/iocon/Makefile | 51 +++++++
> board/gdsys/iocon/config.mk | 24 ++++
> board/gdsys/iocon/iocon.c | 302 +++++++++++++++++++++++++++++++++++++++++++
> board/gdsys/iocon/osd.c | 255 ++++++++++++++++++++++++++++++++++++
> board/gdsys/iocon/osd.h | 29 ++++
> boards.cfg | 1 +
> include/configs/iocon.h | 242 ++++++++++++++++++++++++++++++++++
> 9 files changed, 906 insertions(+), 0 deletions(-)
> create mode 100644 board/gdsys/iocon/Makefile
> create mode 100644 board/gdsys/iocon/config.mk
> create mode 100644 board/gdsys/iocon/iocon.c
> create mode 100644 board/gdsys/iocon/osd.c
> create mode 100644 board/gdsys/iocon/osd.h
> create mode 100644 include/configs/iocon.h
It seems thius board is very similar to the "io" board; especially
board/gdsys/iocon/{io,iocon}.c and include/configs/{ip,iocon}.h share
many, many identical lines.
Please factor out such common code. Eventually, a single board entry
with two configurations is sufficient?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Make it right before you make it faster.
next prev parent reply other threads:[~2010-10-13 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 11:58 [U-Boot] [PATCH] ppc4xx: Add CATCenter IoCon 405EP board support Dirk Eibach
2010-10-13 12:21 ` Wolfgang Denk
2010-10-13 12:28 ` Eibach, Dirk
2010-10-13 14:18 ` Wolfgang Denk
2010-10-13 14:46 ` Wolfgang Denk [this message]
2010-10-14 7:04 ` Eibach, Dirk
2010-10-14 8:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101013144647.D14DD1365CF@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox