From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Thu, 14 Oct 2010 15:26:40 +0200 Subject: [U-Boot] [PATCH] Add support for the MPC5121e USB Host controller. In-Reply-To: <1282455714-12834-1-git-send-email-d.dusha@gmail.com> References: <1282455714-12834-1-git-send-email-d.dusha@gmail.com> Message-ID: <20101014132640.078A8134F26@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Damien Dusha, In message <1282455714-12834-1-git-send-email-d.dusha@gmail.com> you wrote: > Add support for the USB Host controller of the MPC5121e, based on the original patch by Francesco Rendine [1]. > > The patch configures the USB Host controller and the on-board UTMI phy, including the Freescale-specific registers as per the Linux kernel driver. > > Tested on the MPC5121ADS platform with various USB mass storage devices. > > [1] http://lists.denx.de/pipermail/u-boot/2009-June/055022.html > > Signed-off-by: Damien Dusha > --- > arch/powerpc/include/asm/immap_512x.h | 4 + > board/freescale/mpc5121ads/mpc5121ads.c | 4 +- > drivers/usb/host/ehci-fsl.c | 137 ++++++++++++++++++++++++++++- > drivers/usb/host/ehci.h | 5 + > include/configs/mpc5121ads.h | 22 +++++- > include/usb/ehci-fsl.h | 149 +++++++++++++++++++++++++------ > 6 files changed, 292 insertions(+), 29 deletions(-) Sorry for the late response. I have to admit that I really dislike the big "#ifndef CONFIG_MPC512X" in drivers/usb/host/ehci-fsl.c - it covers basicly all of the existing code, and adds an alternative implementation for MPC512x. I think this should better be handled in a separate driver. Patch following. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The ultimate barrier is one's viewpoint. - Terry Pratchett, _The Dark Side of the Sun_