public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] ehci-pci: print hccr, hcor and hc_lenght
@ 2010-10-15 13:53 Florian Fainelli
  2010-10-16 10:01 ` Remy Bohmer
  0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2010-10-15 13:53 UTC (permalink / raw)
  To: u-boot

It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
successfully registered, and at the correct location.

Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Changes since v1:
- replaced printf by debug

diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index 047902a..cff3438 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -53,6 +53,10 @@ int ehci_hcd_init(void)
 	hcor = (struct ehci_hcor *)((uint32_t) hccr +
 			HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
 
+	debug("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
+			(uint32_t)hccr, (uint32_t)hcor,
+			(uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
+
 	return 0;
 }
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH v2] ehci-pci: print hccr, hcor and hc_lenght
  2010-10-15 13:53 [U-Boot] [PATCH v2] ehci-pci: print hccr, hcor and hc_lenght Florian Fainelli
@ 2010-10-16 10:01 ` Remy Bohmer
  0 siblings, 0 replies; 2+ messages in thread
From: Remy Bohmer @ 2010-10-16 10:01 UTC (permalink / raw)
  To: u-boot

Hi,

2010/10/15 Florian Fainelli <f.fainelli@gmail.com>:
> It is useful to know the EHCI-PCI hccr, hcor and hc_lenght to make sure it was
> successfully registered, and at the correct location.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> Changes since v1:
> - replaced printf by debug
>
> diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> index 047902a..cff3438 100644
> --- a/drivers/usb/host/ehci-pci.c
> +++ b/drivers/usb/host/ehci-pci.c
> @@ -53,6 +53,10 @@ int ehci_hcd_init(void)
> ? ? ? ?hcor = (struct ehci_hcor *)((uint32_t) hccr +
> ? ? ? ? ? ? ? ? ? ? ? ?HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
>
> + ? ? ? debug("EHCI-PCI init hccr 0x%x and hcor 0x%x hc_length %d\n",
> + ? ? ? ? ? ? ? ? ? ? ? (uint32_t)hccr, (uint32_t)hcor,
> + ? ? ? ? ? ? ? ? ? ? ? (uint32_t)HC_LENGTH(ehci_readl(&hccr->cr_capbase)));
> +
> ? ? ? ?return 0;
> ?}

Applied to u-boot-usb.
Thanks.

Remy

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-16 10:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-15 13:53 [U-Boot] [PATCH v2] ehci-pci: print hccr, hcor and hc_lenght Florian Fainelli
2010-10-16 10:01 ` Remy Bohmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox