From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 15 Oct 2010 21:08:13 +0200
Subject: [U-Boot] [PATCH V2 1/1] IMX: rename mx51 to mx5
In-Reply-To: <1287155158-16801-1-git-send-email-r64343@freescale.com>
References: <1287155158-16801-1-git-send-email-r64343@freescale.com>
Message-ID: <20101015190813.C6D821365CF@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Jason Liu,

In message <1287155158-16801-1-git-send-email-r64343@freescale.com> you wrote:
...
> -	freq = decode_pll(mxc_plls[PLL1_CLOCK], CONFIG_MX51_HCLK_FREQ);
> +	freq = decode_pll(mxc_plls[PLL1_CLOCK], CONFIG_HCLK_FREQ);
...
> -	clockinfo,	CONFIG_SYS_MAXARGS,	1,	do_mx51_showclocks,
> -	"display mx51 clocks\n",
> +	clockinfo,	CONFIG_SYS_MAXARGS,	1,	do_showclocks,
> +	"display clocks\n",
...
> -	lastinc = val / (CONFIG_MX51_CLK32 / CONFIG_SYS_HZ);
> +	lastinc = val / (CONFIG_CLK32 / CONFIG_SYS_HZ);

I'm not happy about these changes.

The old names, containing "MX51" may have been too narrow in their
naming; but the new names are now way too general.

"CONFIG_CLK32" or "CONFIG_HCLK_FREQ" look like generic config options
that apply to any processor or board, or at least potentially to a
wider range.  This is kind of name space pollution.

I understand that all these names are specific to the mx5 family of
processors only, right?

Recent submissions to the Linux kernel seem to use a "MX5" string when
referring to these processors, like in:

- commit messages:

	ARM: mx5: Add Nand clock support
	ARM: mx5: dynamically register mxc-nand device
	ARM: mx5: dynamically register imx-i2c devices

- directory names:

	arch/arm/mach-mx5/

- preprocessor variables:

	MX5_USBOTHER_REGS_OFFSET
	MX5_USB_UTMI_PHYCTRL1_PLLDIV_MASK

etc.

I suggest we do the same. Please add a "mx5" resp. "MX5" to the new
identifier names.

Please also keep in mind that CONFIG_* options should be documented in
the README.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"May your future be limited only by your dreams."
- Christa McAuliffe