public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] Ensure gd->ram_size end stays on 4k page boundary when 'hiding' RAM
Date: Fri, 15 Oct 2010 21:33:05 +0200	[thread overview]
Message-ID: <20101015193305.A47841365CF@gemini.denx.de> (raw)
In-Reply-To: <4CB8A35A.7020500@rocketmail.com>

Dear Gray Remlin,

In message <4CB8A35A.7020500@rocketmail.com> you wrote:
> Signed-off-by: Gray Remlin <g_remlin@rocketmail.com>
> ---
>  arch/arm/lib/board.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c
> index 22bd2c9..2f0d5c4 100644
> --- a/arch/arm/lib/board.c
> +++ b/arch/arm/lib/board.c
> @@ -532,7 +532,7 @@ void board_init_f (ulong bootflag)
>          * memory size from the SDRAM controller setup will have to
>          * get fixed.
>          */
> -       gd->ram_size -= CONFIG_SYS_MEM_TOP_HIDE;
> +       gd->ram_size -= roundup(CONFIG_SYS_MEM_TOP_HIDE, 4096);
>  #endif
> 
>         addr = CONFIG_SYS_SDRAM_BASE + gd->ram_size;

If such a change gets implemented, it should be implemented for
PowerPC as well, plus the description in the README should be
adjusted.

On the other hand, I can see no really good reason to implement such a
fix, as the description in the README is precise enough about this
item, and there is no good reason to assume that this feature would
ever be enabled on any other systems but those with this specific
PowerPC processor.

I recommend to just drop this patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
365 Days of drinking Lo-Cal beer.                       = 1 Lite-year

      reply	other threads:[~2010-10-15 19:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-15 18:54 [U-Boot] [PATCH v2] Ensure gd->ram_size end stays on 4k page boundary when 'hiding' RAM Gray Remlin
2010-10-15 19:33 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101015193305.A47841365CF@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox