public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add sys_proto.h for arch-armv7
Date: Sat, 16 Oct 2010 16:54:43 +0200	[thread overview]
Message-ID: <20101016145443.6755C134F26@gemini.denx.de> (raw)
In-Reply-To: <20101015233455.4049.16990.stgit@zaytsev.su>

Dear Alexey Zaytsev,

In message <20101015233455.4049.16990.stgit@zaytsev.su> you wrote:
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
> ---
> 
> Hi.
> 
> U-boot won't build for Versatile Express (ca9x4_ct_vxp)
> without this patch. I'm not sure why the syslib is made
> armv7-specific, as it looks quite generic to me, but
> I'll leave this to the original authors.
> 
> 
>  arch/arm/include/asm/arch-armv7/sys_proto.h |   31 +++++++++++++++++++++++++++
>  1 files changed, 31 insertions(+), 0 deletions(-)

NAK.  This needs better cleanup.

Instead of adding yet another header file just to fix this current
issue, this should really be cleaned up.

We aleady have such prototype declarations in

	arch/arm/include/asm/arch-omap24xx/sys_proto.h
	arch/arm/include/asm/arch-omap3/sys_proto.h
and	arch/arm/include/asm/arch-omap4/sys_proto.h

And we have implementations in

	arch/arm/cpu/armv7/syslib.c
	board/apollon/sys_info.c
and	board/ti/omap2420h4/sys_info.c


All this needs to be moved to a single, common place.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one  instruction  --  from  which,  by induction, one can deduce that
every program can be reduced to one instruction which doesn't work.

  reply	other threads:[~2010-10-16 14:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-13 18:40 [U-Boot] Pull request: u-boot-arm Wolfgang Denk
2010-10-13 19:00 ` Wolfgang Denk
2010-10-15 23:38   ` [U-Boot] [PATCH] Add sys_proto.h for arch-armv7 Alexey Zaytsev
2010-10-16 14:54     ` Wolfgang Denk [this message]
2010-10-17  8:18       ` Alexey Zaytsev
2010-10-17 18:32         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101016145443.6755C134F26@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox