From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Sun, 17 Oct 2010 09:33:29 +0200
Subject: [U-Boot] [PATCH v2 1/5] Build: Add "board options" column to
	boards.cfg
In-Reply-To: <4CBA3FC0.1010300@emk-elektronik.de>
References: <1286790310-5865-1-git-send-email-wd@denx.de>
	<1287273462-14872-2-git-send-email-wd@denx.de>
	<4CBA3FC0.1010300@emk-elektronik.de>
Message-ID: <20101017073329.E737B1365CF@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Reinhard Meyer,

In message <4CBA3FC0.1010300@emk-elektronik.de> you wrote:
> 
>  > In case of simple options like '256M_U_BOOT', these expand to
>  > "#define CONFIG_MK_256M_U_BOOT 1" in config.h . In case of
>  > assignments like 'RAM=8192', these expand to "#define CONFIG_MK_RAM
>  > 8192" in config.h .
> 
> Umm, what about:
> 
>  > Out of principle: please omit the "1" in all such cases unless you
>  > really want to pass or test for such a numeric value anywhere. As far
>  > as I can tell all relevant code uses only "#ifdef" or "defined(...)",
>  > so not to confuse people better omit the irrelevant value.
> 
> Your own words ;)

Yes, I know.

> If someone really needs the "1", they can always write "=1" in boards.cfg.

Yes, you are right.

But note that this is not new behaviour, but the way it has been
working all the time. I decided intentionally NOT to change this now,
to avoid changing too many things at the same time.

The change itself i trivial and can be performed (and tested)
separataely.

I have a number of othe rclean-up actions on my list, but for now I
want to get really big changes in.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A failure will not appear until a unit has passed final inspection.