From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/1] IMX: rename mx51 to mx5
Date: Sun, 17 Oct 2010 16:06:40 +0200 [thread overview]
Message-ID: <20101017140640.5088613558AD@gemini.denx.de> (raw)
In-Reply-To: <3850A844E6A3854C827AC5C0BEC7B60A2B0596@zch01exm23.fsl.freescale.net>
Dear Liu Hui-R64343,
In message <3850A844E6A3854C827AC5C0BEC7B60A2B0596@zch01exm23.fsl.freescale.net> you wrote:
>
> > I suggest we do the same. Please add a "mx5" resp. "MX5" to the new
> > identifier names.
>
> Yes, agree.
Thanks.
> > Please also keep in mind that CONFIG_* options should be documented in
> > the README.
>
> Do you mean all the specific CONFIG_* options in
> include/configs/boardname.h should be documented?
> I found lots of that is not doing what you called for? :(
Yes, we have not always been that strict, but we try to improve.
> BTW, which definition is better?
>
> CONFIG_SYS_MX5_HCLK_FREQ 24000000
> CONFIG_MX5_HCLK_FREQ 24000000
>
> According to the REAME, I prefer to the former, what do you think.
Indeed CONFIG_SYS_* seems more appropriate here. I would probably call
this "CONFIG_SYS_MX5_HCLK" ("CLK" and "FREQ" seem a bit redundant
here).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Some programming languages manage to absorb change, but withstand
progress. -- Epigrams in Programming, ACM SIGPLAN Sept. 1982
prev parent reply other threads:[~2010-10-17 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 15:05 [U-Boot] [PATCH V2 1/1] IMX: rename mx51 to mx5 Jason Liu
2010-10-15 19:08 ` Wolfgang Denk
2010-10-17 9:04 ` Liu Hui-R64343
2010-10-17 14:06 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101017140640.5088613558AD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox