From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add sys_proto.h for arch-armv7
Date: Sun, 17 Oct 2010 20:32:10 +0200 [thread overview]
Message-ID: <20101017183210.7FE1013558AD@gemini.denx.de> (raw)
In-Reply-To: <AANLkTim6fAZCsUFanEv2OCSvmvtiygrERRv3CirrG3N9@mail.gmail.com>
Dear Alexey Zaytsev,
In message <AANLkTim6fAZCsUFanEv2OCSvmvtiygrERRv3CirrG3N9@mail.gmail.com> you wrote:
>
> >> U-boot won't build for Versatile Express (ca9x4_ct_vxp)
> >> without this patch. I'm not sure why the syslib is made
> >> armv7-specific, as it looks quite generic to me, but
> >> I'll leave this to the original authors.
> >>
> >>
> >> arch/arm/include/asm/arch-armv7/sys_proto.h | 31 +++++++++++++++++++++++++++
> >> 1 files changed, 31 insertions(+), 0 deletions(-)
> >
> > NAK. This needs better cleanup.
>
> Well, I'm just a simple user who wants his u-boot to build, don't know
> much about programmin' ;)
>
> > Instead of adding yet another header file just to fix this current
> > issue, this should really be cleaned up.
>
> I totally agree, but could you please rise the issue with the involved
> maintainers, and fix the vexpress build in the mean time?
> Or also break the build for the omap boards?
Sometimes poor code sneaks in unnoticed. It starts spreading, until it
gets noticed. This time you got hit, sorry for that. But that's how
it goes. Many of us have been in similar situations before.
We need to fix this. I will not have yet another such file added.
Dear Sandeep,
do you happen to have this on your to-do list?
For reference, here is what I complained about:
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/86504/focus=86664
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Everything should be made as simple as possible, but not simpler."
- Albert Einstein
prev parent reply other threads:[~2010-10-17 18:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-13 18:40 [U-Boot] Pull request: u-boot-arm Wolfgang Denk
2010-10-13 19:00 ` Wolfgang Denk
2010-10-15 23:38 ` [U-Boot] [PATCH] Add sys_proto.h for arch-armv7 Alexey Zaytsev
2010-10-16 14:54 ` Wolfgang Denk
2010-10-17 8:18 ` Alexey Zaytsev
2010-10-17 18:32 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101017183210.7FE1013558AD@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox