From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mainline arm926ejs: Fix two occurrences of illegal syntax assembler instructions
Date: Thu, 21 Oct 2010 20:06:45 +0200 [thread overview]
Message-ID: <20101021180645.C2244136320@gemini.denx.de> (raw)
In-Reply-To: <4CC06B1A.2070401@rocketmail.com>
Dear Gray Remlin,
In message <4CC06B1A.2070401@rocketmail.com> you wrote:
> HEAD is at commit c62491d2602b353a815a909e27eec0df9f2c06a2
> Untested due to link error bug
What makes you think this is "illegal syntax" ?
gas seems to digest this just fine.
Which sort of tool chain are you using?
> ---
> arch/arm/cpu/arm926ejs/start.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Hm, if you really want to fix this, then please fix all occurrences:
-> find arch/arm | xargs grep 'add r[0-9], r[0-9][^,]*$'
arch/arm/cpu/arm1136/start.S: add r0, r9 /* r0 <- location to fix up in RAM */
arch/arm/cpu/arm1136/start.S: add r1, r9 /* r1 <- relocated sym addr */
arch/arm/cpu/arm926ejs/start.S: add r0, r9 /* r0 <- location to fix up in RAM */
arch/arm/cpu/arm926ejs/start.S: add r1, r9 /* r1 <- relocated sym addr */
arch/arm/cpu/armv7/start.S: add r0, r9 /* r0 <- location to fix up in RAM */
arch/arm/cpu/armv7/start.S: add r1, r9 /* r1 <- relocated sym addr */
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
If all you have is a hammer, everything looks like a nail.
prev parent reply other threads:[~2010-10-21 18:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 16:32 [U-Boot] [PATCH] mainline arm926ejs: Fix two occurrences of illegal syntax assembler instructions Gray Remlin
2010-10-21 18:06 ` Wolfgang Denk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021180645.C2244136320@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox