From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block
Date: Thu, 21 Oct 2010 22:22:57 +0200 [thread overview]
Message-ID: <20101021202257.DF79A1359B7@gemini.denx.de> (raw)
In-Reply-To: <4CC09695.6070702@rocketmail.com>
Dear Gray Remlin,
In message <4CC09695.6070702@rocketmail.com> you wrote:
> Labels added to endifs to aid readability of the net/bootp.c file.
> A block of code was marked for conditional compilation but the condition
> could never arise, the ifdef\endif code block has been deleted.
...
> -#if defined(CONFIG_CMD_DHCP)
> - *e++ = 53; /* DHCP Message Type */
> - *e++ = 1;
> - *e++ = DHCP_DISCOVER;
> -
> - *e++ = 57; /* Maximum DHCP Message Size */
> - *e++ = 2;
> - *e++ = (576 - 312 + OPT_SIZE) >> 16;
> - *e++ = (576 - 312 + OPT_SIZE) & 0xff;
> -#endif
What makes you think CONFIG_CMD_DHCP was never used? There are 270+
boards that use this!
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Technology is dominated by those who manage what they do not under-
stand.
next prev parent reply other threads:[~2010-10-21 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:37 [U-Boot] [PATCH] net: Add labels to endifs and remove impossible conditional code block Gray Remlin
2010-10-21 20:22 ` Wolfgang Denk [this message]
2010-10-21 20:37 ` Reinhard Meyer
2010-10-21 20:46 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101021202257.DF79A1359B7@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox