From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci
Date: Fri, 22 Oct 2010 12:56:34 +0530 [thread overview]
Message-ID: <20101022072634.GA8597@Hardy> (raw)
In-Reply-To: <20101021203009.3FDEC1359B7@gemini.denx.de>
hi Wolfgang,
On Thu Oct 21, 2010 at 10:30:09PM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
>
> In message <1287690158-6055-1-git-send-email-urwithsughosh@gmail.com> you wrote:
> > Move and rename common header files from under board/davinci to the
> > standard include file path.
> >
> > Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> > ---
> > This patch is needed for adding board support for the hawkboard which
> > uses nand_spl based boot mechanism.
>
> Why would that be the case?
The board file is symlinked under the nand_spl/board directory and
we cannot do relative path based file inclusion.
> I don't like to move davinci specific headers into the top level
> include/ directory. That's inherently wrong.
>
> If these headers are indeed common to all davinci boards, they should
> probably be moved to arch/arm/cpu/arm926ejs/davinci/
Ok. In that case, i guess i can keep them in the same place. Would
rename them as davinci_misc.h and da8xx_common.h, and add the
include path in my board's config.mk. Is this fine.
>
> > board/davinci/common/misc.c | 2 +-
> > board/davinci/common/misc.h | 54 -----------------------------
> > board/davinci/da8xxevm/common.c | 2 +-
> > board/davinci/da8xxevm/common.h | 30 ----------------
> > board/davinci/da8xxevm/da830evm.c | 4 +-
> > board/davinci/da8xxevm/da850evm.c | 4 +-
> > board/davinci/dm355evm/dm355evm.c | 2 +-
> > board/davinci/dm355leopard/dm355leopard.c | 2 +-
> > board/davinci/dm365evm/dm365evm.c | 2 +-
> > board/davinci/dvevm/dvevm.c | 2 +-
> > board/davinci/schmoogie/schmoogie.c | 2 +-
> > board/davinci/sffsdr/sffsdr.c | 2 +-
> > board/davinci/sonata/sonata.c | 2 +-
> > include/da8xx_common.h | 30 ++++++++++++++++
> > include/davinci_misc.h | 54 +++++++++++++++++++++++++++++
> > 15 files changed, 97 insertions(+), 97 deletions(-)
> > delete mode 100644 board/davinci/common/misc.h
> > delete mode 100644 board/davinci/da8xxevm/common.h
> > create mode 100644 include/da8xx_common.h
> > create mode 100644 include/davinci_misc.h
>
> Please use the "-M" option with "git format-patch" to make it detect
> such renames.
Ok. Will do. Thanks.
-sughosh
next prev parent reply other threads:[~2010-10-22 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:42 [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci Sughosh Ganu
2010-10-21 20:30 ` Wolfgang Denk
2010-10-22 7:26 ` Sughosh Ganu [this message]
2010-10-22 7:56 ` Wolfgang Denk
2010-10-22 8:04 ` Sughosh Ganu
2010-10-22 8:26 ` Wolfgang Denk
2010-10-22 8:46 ` Sughosh Ganu
2010-10-22 9:47 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022072634.GA8597@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox