[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Sughosh Ganu]

Move and rename common header files from under board/davinci to the
standard include file path. 

Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
---
This patch is needed for adding board support for the hawkboard which
uses nand_spl based boot mechanism.

 board/davinci/common/misc.c               |    2 +-
 board/davinci/common/misc.h               |   54 -----------------------------
 board/davinci/da8xxevm/common.c           |    2 +-
 board/davinci/da8xxevm/common.h           |   30 ----------------
 board/davinci/da8xxevm/da830evm.c         |    4 +-
 board/davinci/da8xxevm/da850evm.c         |    4 +-
 board/davinci/dm355evm/dm355evm.c         |    2 +-
 board/davinci/dm355leopard/dm355leopard.c |    2 +-
 board/davinci/dm365evm/dm365evm.c         |    2 +-
 board/davinci/dvevm/dvevm.c               |    2 +-
 board/davinci/schmoogie/schmoogie.c       |    2 +-
 board/davinci/sffsdr/sffsdr.c             |    2 +-
 board/davinci/sonata/sonata.c             |    2 +-
 include/da8xx_common.h                    |   30 ++++++++++++++++
 include/davinci_misc.h                    |   54 +++++++++++++++++++++++++++++
 15 files changed, 97 insertions(+), 97 deletions(-)
 delete mode 100644 board/davinci/common/misc.h
 delete mode 100644 board/davinci/da8xxevm/common.h
 create mode 100644 include/da8xx_common.h
 create mode 100644 include/davinci_misc.h

diff --git a/board/davinci/common/misc.c b/board/davinci/common/misc.c
index b60a46e..28750b1 100644
--- a/board/davinci/common/misc.c
+++ b/board/davinci/common/misc.c
@@ -29,7 +29,7 @@
 #include <net.h>
 #include <asm/arch/hardware.h>
 #include <asm/io.h>
-#include "misc.h"
+#include <davinci_misc.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/common/misc.h b/board/davinci/common/misc.h
deleted file mode 100644
index a6ac3b9..0000000
--- a/board/davinci/common/misc.h
+++ /dev/null
@@ -1,54 +0,0 @@
-/*
- * Copyright (C) 2008 Lyrtech <www.lyrtech.com>
- *
- * See file CREDITS for list of people who contributed to this
- * project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
-
-#ifndef __MISC_H
-#define __MISC_H
-
-/* pin muxer definitions */
-#define PIN_MUX_NUM_FIELDS	8	/* Per register */
-#define PIN_MUX_FIELD_SIZE	4	/* n in bits */
-#define PIN_MUX_FIELD_MASK	((1 << PIN_MUX_FIELD_SIZE) - 1)
-
-/* pin definition */
-struct pinmux_config {
-	dv_reg		*mux;		/* Address of mux register */
-	unsigned char	value;		/* Value to set in field */
-	unsigned char	field;		/* field number */
-};
-
-/* pin table definition */
-struct pinmux_resource {
-	const struct pinmux_config	*pins;
-	const int 			n_pins;
-};
-
-#define PINMUX_ITEM(item) { \
-				.pins = item, \
-				.n_pins = ARRAY_SIZE(item) \
-			  }
-
-int dvevm_read_mac_address(uint8_t *buf);
-void davinci_sync_env_enetaddr(uint8_t *rom_enetaddr);
-int davinci_configure_pin_mux(const struct pinmux_config *pins, int n_pins);
-int davinci_configure_pin_mux_items(const struct pinmux_resource *item,
-				    int n_items);
-
-#endif /* __MISC_H */
diff --git a/board/davinci/da8xxevm/common.c b/board/davinci/da8xxevm/common.c
index 9cd5204..f2d0266 100644
--- a/board/davinci/da8xxevm/common.c
+++ b/board/davinci/da8xxevm/common.c
@@ -20,7 +20,7 @@
 
 #include <asm/io.h>
 #include <asm/arch/hardware.h>
-#include "common.h"
+#include <da8xx_common.h>
 
 #ifndef CONFIG_USE_IRQ
 void irq_init(void)
diff --git a/board/davinci/da8xxevm/common.h b/board/davinci/da8xxevm/common.h
deleted file mode 100644
index 7ae63a6..0000000
--- a/board/davinci/da8xxevm/common.h
+++ /dev/null
@@ -1,30 +0,0 @@
-/*
- * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
- * (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
- */
-
-#ifndef __COMMON_H
-#define __COMMON_H
-
-struct lpsc_resource {
-	const int	lpsc_no;
-};
-
-void irq_init(void);
-int da8xx_configure_lpsc_items(const struct lpsc_resource *item,
-				    int n_items);
-
-#endif /* __COMMON_H */
diff --git a/board/davinci/da8xxevm/da830evm.c b/board/davinci/da8xxevm/da830evm.c
index 8a9f988..16eb8d2 100644
--- a/board/davinci/da8xxevm/da830evm.c
+++ b/board/davinci/da8xxevm/da830evm.c
@@ -40,8 +40,8 @@
 #include <asm/arch/emif_defs.h>
 #include <asm/arch/emac_defs.h>
 #include <asm/io.h>
-#include "../common/misc.h"
-#include "common.h"
+#include <davinci_misc.h>
+#include <da8xx_common.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/da8xxevm/da850evm.c b/board/davinci/da8xxevm/da850evm.c
index c8c5e1b..efb2605 100644
--- a/board/davinci/da8xxevm/da850evm.c
+++ b/board/davinci/da8xxevm/da850evm.c
@@ -29,8 +29,8 @@
 #include <asm/arch/emif_defs.h>
 #include <asm/arch/emac_defs.h>
 #include <asm/io.h>
-#include "../common/misc.h"
-#include "common.h"
+#include <davinci_misc.h>
+#include <da8xx_common.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/dm355evm/dm355evm.c b/board/davinci/dm355evm/dm355evm.c
index 87f284c..62b7e4f 100644
--- a/board/davinci/dm355evm/dm355evm.c
+++ b/board/davinci/dm355evm/dm355evm.c
@@ -22,7 +22,7 @@
 #include <asm/arch/hardware.h>
 #include <asm/arch/emif_defs.h>
 #include <asm/arch/nand_defs.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 #include <net.h>
 #include <netdev.h>
 
diff --git a/board/davinci/dm355leopard/dm355leopard.c b/board/davinci/dm355leopard/dm355leopard.c
index e89786e..f3e2b90 100644
--- a/board/davinci/dm355leopard/dm355leopard.c
+++ b/board/davinci/dm355leopard/dm355leopard.c
@@ -22,7 +22,7 @@
 #include <asm/arch/hardware.h>
 #include <asm/arch/gpio_defs.h>
 #include <asm/arch/nand_defs.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 #include <net.h>
 #include <netdev.h>
 
diff --git a/board/davinci/dm365evm/dm365evm.c b/board/davinci/dm365evm/dm365evm.c
index 85dbe2a..48ed5ba 100644
--- a/board/davinci/dm365evm/dm365evm.c
+++ b/board/davinci/dm365evm/dm365evm.c
@@ -24,7 +24,7 @@
 #include <asm/arch/nand_defs.h>
 #include <asm/arch/gpio_defs.h>
 #include <netdev.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/dvevm/dvevm.c b/board/davinci/dvevm/dvevm.c
index 073c21a..d254f33 100644
--- a/board/davinci/dvevm/dvevm.c
+++ b/board/davinci/dvevm/dvevm.c
@@ -27,7 +27,7 @@
 #include <common.h>
 #include <i2c.h>
 #include <asm/arch/hardware.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/schmoogie/schmoogie.c b/board/davinci/schmoogie/schmoogie.c
index 80a0f9f..b09a4bd 100644
--- a/board/davinci/schmoogie/schmoogie.c
+++ b/board/davinci/schmoogie/schmoogie.c
@@ -27,7 +27,7 @@
 #include <common.h>
 #include <i2c.h>
 #include <asm/arch/hardware.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/board/davinci/sffsdr/sffsdr.c b/board/davinci/sffsdr/sffsdr.c
index 657cf2b..60e5456 100644
--- a/board/davinci/sffsdr/sffsdr.c
+++ b/board/davinci/sffsdr/sffsdr.c
@@ -30,7 +30,7 @@
 #include <common.h>
 #include <i2c.h>
 #include <asm/arch/hardware.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 
 #define DAVINCI_A3CR     (0x01E00014)	/* EMIF-A CS3 config register. */
 #define DAVINCI_A3CR_VAL (0x3FFFFFFD)	/* EMIF-A CS3 value for FPGA. */
diff --git a/board/davinci/sonata/sonata.c b/board/davinci/sonata/sonata.c
index 1dc42c4..d85ae5a 100644
--- a/board/davinci/sonata/sonata.c
+++ b/board/davinci/sonata/sonata.c
@@ -28,7 +28,7 @@
 #include <nand.h>
 #include <asm/arch/nand_defs.h>
 #include <asm/arch/hardware.h>
-#include "../common/misc.h"
+#include <davinci_misc.h>
 
 DECLARE_GLOBAL_DATA_PTR;
 
diff --git a/include/da8xx_common.h b/include/da8xx_common.h
new file mode 100644
index 0000000..7ae63a6
--- /dev/null
+++ b/include/da8xx_common.h
@@ -0,0 +1,30 @@
+/*
+ * Copyright (C) 2010 Texas Instruments Incorporated - http://www.ti.com/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __COMMON_H
+#define __COMMON_H
+
+struct lpsc_resource {
+	const int	lpsc_no;
+};
+
+void irq_init(void);
+int da8xx_configure_lpsc_items(const struct lpsc_resource *item,
+				    int n_items);
+
+#endif /* __COMMON_H */
diff --git a/include/davinci_misc.h b/include/davinci_misc.h
new file mode 100644
index 0000000..a6ac3b9
--- /dev/null
+++ b/include/davinci_misc.h
@@ -0,0 +1,54 @@
+/*
+ * Copyright (C) 2008 Lyrtech <www.lyrtech.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __MISC_H
+#define __MISC_H
+
+/* pin muxer definitions */
+#define PIN_MUX_NUM_FIELDS	8	/* Per register */
+#define PIN_MUX_FIELD_SIZE	4	/* n in bits */
+#define PIN_MUX_FIELD_MASK	((1 << PIN_MUX_FIELD_SIZE) - 1)
+
+/* pin definition */
+struct pinmux_config {
+	dv_reg		*mux;		/* Address of mux register */
+	unsigned char	value;		/* Value to set in field */
+	unsigned char	field;		/* field number */
+};
+
+/* pin table definition */
+struct pinmux_resource {
+	const struct pinmux_config	*pins;
+	const int 			n_pins;
+};
+
+#define PINMUX_ITEM(item) { \
+				.pins = item, \
+				.n_pins = ARRAY_SIZE(item) \
+			  }
+
+int dvevm_read_mac_address(uint8_t *buf);
+void davinci_sync_env_enetaddr(uint8_t *rom_enetaddr);
+int davinci_configure_pin_mux(const struct pinmux_config *pins, int n_pins);
+int davinci_configure_pin_mux_items(const struct pinmux_resource *item,
+				    int n_items);
+
+#endif /* __MISC_H */
-- 
1.7.0.4

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Wolfgang Denk]

Dear Sughosh Ganu,

In message <1287690158-6055-1-git-send-email-urwithsughosh@gmail.com> you wrote:
> Move and rename common header files from under board/davinci to the
> standard include file path. 
> 
> Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> ---
> This patch is needed for adding board support for the hawkboard which
> uses nand_spl based boot mechanism.

Why would that be the case?

I don't like to move davinci specific headers into the top level
include/ directory. That's inherently wrong.

If these headers are indeed common to all davinci boards, they should
probably be moved to arch/arm/cpu/arm926ejs/davinci/


>  board/davinci/common/misc.c               |    2 +-
>  board/davinci/common/misc.h               |   54 -----------------------------
>  board/davinci/da8xxevm/common.c           |    2 +-
>  board/davinci/da8xxevm/common.h           |   30 ----------------
>  board/davinci/da8xxevm/da830evm.c         |    4 +-
>  board/davinci/da8xxevm/da850evm.c         |    4 +-
>  board/davinci/dm355evm/dm355evm.c         |    2 +-
>  board/davinci/dm355leopard/dm355leopard.c |    2 +-
>  board/davinci/dm365evm/dm365evm.c         |    2 +-
>  board/davinci/dvevm/dvevm.c               |    2 +-
>  board/davinci/schmoogie/schmoogie.c       |    2 +-
>  board/davinci/sffsdr/sffsdr.c             |    2 +-
>  board/davinci/sonata/sonata.c             |    2 +-
>  include/da8xx_common.h                    |   30 ++++++++++++++++
>  include/davinci_misc.h                    |   54 +++++++++++++++++++++++++++++
>  15 files changed, 97 insertions(+), 97 deletions(-)
>  delete mode 100644 board/davinci/common/misc.h
>  delete mode 100644 board/davinci/da8xxevm/common.h
>  create mode 100644 include/da8xx_common.h
>  create mode 100644 include/davinci_misc.h

Please use the "-M" option with "git format-patch" to make it detect
such renames.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If programming was easy, they wouldn't need something as  complicated
as a human being to do it, now would they?
                       - L. Wall & R. L. Schwartz, _Programming Perl_

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Sughosh Ganu]

hi Wolfgang,
On Thu Oct 21, 2010 at 10:30:09PM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <1287690158-6055-1-git-send-email-urwithsughosh@gmail.com> you wrote:
> > Move and rename common header files from under board/davinci to the
> > standard include file path. 
> > 
> > Signed-off-by: Sughosh Ganu <urwithsughosh@gmail.com>
> > ---
> > This patch is needed for adding board support for the hawkboard which
> > uses nand_spl based boot mechanism.
> 
> Why would that be the case?

  The board file is symlinked under the nand_spl/board directory and
  we cannot do relative path based file inclusion.


> I don't like to move davinci specific headers into the top level
> include/ directory. That's inherently wrong.
> 
> If these headers are indeed common to all davinci boards, they should
> probably be moved to arch/arm/cpu/arm926ejs/davinci/

  Ok. In that case, i guess i can keep them in the same place. Would
  rename them as davinci_misc.h and da8xx_common.h, and add the
  include path in my board's config.mk. Is this fine.

> 
> >  board/davinci/common/misc.c               |    2 +-
> >  board/davinci/common/misc.h               |   54 -----------------------------
> >  board/davinci/da8xxevm/common.c           |    2 +-
> >  board/davinci/da8xxevm/common.h           |   30 ----------------
> >  board/davinci/da8xxevm/da830evm.c         |    4 +-
> >  board/davinci/da8xxevm/da850evm.c         |    4 +-
> >  board/davinci/dm355evm/dm355evm.c         |    2 +-
> >  board/davinci/dm355leopard/dm355leopard.c |    2 +-
> >  board/davinci/dm365evm/dm365evm.c         |    2 +-
> >  board/davinci/dvevm/dvevm.c               |    2 +-
> >  board/davinci/schmoogie/schmoogie.c       |    2 +-
> >  board/davinci/sffsdr/sffsdr.c             |    2 +-
> >  board/davinci/sonata/sonata.c             |    2 +-
> >  include/da8xx_common.h                    |   30 ++++++++++++++++
> >  include/davinci_misc.h                    |   54 +++++++++++++++++++++++++++++
> >  15 files changed, 97 insertions(+), 97 deletions(-)
> >  delete mode 100644 board/davinci/common/misc.h
> >  delete mode 100644 board/davinci/da8xxevm/common.h
> >  create mode 100644 include/da8xx_common.h
> >  create mode 100644 include/davinci_misc.h
> 
> Please use the "-M" option with "git format-patch" to make it detect
> such renames.

  Ok. Will do. Thanks.

-sughosh

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Wolfgang Denk]

Dear Sughosh Ganu,

In message <20101022072634.GA8597@Hardy> you wrote:
>
> > > This patch is needed for adding board support for the hawkboard which
> > > uses nand_spl based boot mechanism.
> > 
> > Why would that be the case?
> 
>   The board file is symlinked under the nand_spl/board directory and
>   we cannot do relative path based file inclusion.

Which points out where the actual problem comes from: relative path
based file inclusion is a Bad Thing and should be avoided.

> > If these headers are indeed common to all davinci boards, they should
> > probably be moved to arch/arm/cpu/arm926ejs/davinci/
> 
>   Ok. In that case, i guess i can keep them in the same place. Would
>   rename them as davinci_misc.h and da8xx_common.h, and add the
>   include path in my board's config.mk. Is this fine.

I don't understand what you man by "keep them in the same place".
Where?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The goal of science is to build better mousetraps. The goal of nature
is to build better mice.

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Sughosh Ganu]

hi Wolfgang,

On Fri Oct 22, 2010 at 09:56:01AM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <20101022072634.GA8597@Hardy> you wrote:
> >
> > > > This patch is needed for adding board support for the hawkboard which
> > > > uses nand_spl based boot mechanism.
> > > 
> > > Why would that be the case?
> > 
> >   The board file is symlinked under the nand_spl/board directory and
> >   we cannot do relative path based file inclusion.
> 
> Which points out where the actual problem comes from: relative path
> based file inclusion is a Bad Thing and should be avoided.

  So then can we remove the relative path based inclusion used by all
  files under board/davinci. We would need to add corresponding path
  entries to the board's config.mk.

> > > If these headers are indeed common to all davinci boards, they should
> > > probably be moved to arch/arm/cpu/arm926ejs/davinci/
> > 
> >   Ok. In that case, i guess i can keep them in the same place. Would
> >   rename them as davinci_misc.h and da8xx_common.h, and add the
> >   include path in my board's config.mk. Is this fine.
> 
> I don't understand what you man by "keep them in the same place".
> Where?

  I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
  keep them in their current location under board/davinci.
  
-sughosh

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Wolfgang Denk]

Dear Sughosh Ganu,

In message <20101022080434.GC8597@Hardy> you wrote:
> 
> > Which points out where the actual problem comes from: relative path
> > based file inclusion is a Bad Thing and should be avoided.
> 
>   So then can we remove the relative path based inclusion used by all
>   files under board/davinci. We would need to add corresponding path
>   entries to the board's config.mk.

Please don't. Assume that all config.mk files are candidates for
removal.

Rather put commonly used header files in places where they can be
found easily.

> > I don't understand what you man by "keep them in the same place".
> > Where?
> 
>   I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
>   keep them in their current location under board/davinci.

That does not solve the problem, then, it seems.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When some people discover the truth, they just can't  understand  why
everybody isn't eager to hear it.

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Sughosh Ganu]

hi Wolfgang,

On Fri Oct 22, 2010 at 10:26:08AM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <20101022080434.GC8597@Hardy> you wrote:
> > 
> > > Which points out where the actual problem comes from: relative path
> > > based file inclusion is a Bad Thing and should be avoided.
> > 
> >   So then can we remove the relative path based inclusion used by all
> >   files under board/davinci. We would need to add corresponding path
> >   entries to the board's config.mk.
> 
> Please don't. Assume that all config.mk files are candidates for
> removal.
> 
> Rather put commonly used header files in places where they can be
> found easily.

  Which is what i was trying in the first place :). Any place other
  than the include directory would need us to specifiy the path to the
  files. Where can we put such information then, if not
  config.mk. Please let me know.


> > > I don't understand what you man by "keep them in the same place".
> > > Where?
> > 
> >   I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
> >   keep them in their current location under board/davinci.
> 
> That does not solve the problem, then, it seems.

  Yes, in case we do not move it to the standard include path, i don't
  think we are adding any value by moving it under the arch
  directory. Please let me know how to proceed on this.

-sughosh

[U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci

[Wolfgang Denk]

Dear Sughosh Ganu,

In message <20101022084641.GD8597@Hardy> you wrote:
>
> > Please don't. Assume that all config.mk files are candidates for
> > removal.
> > 
> > Rather put commonly used header files in places where they can be
> > found easily.
> 
>   Which is what i was trying in the first place :). Any place other
>   than the include directory would need us to specifiy the path to the
>   files. Where can we put such information then, if not
>   config.mk. Please let me know.

If you have common code and local header files that are only needed by
that code you should place this into the
arch/arm/cpu/arm926ejs/davinci/ directory, and use the #include "..."
notation.

Headers that are architecture specific, but otherwise global for all
boards, should probably go to arch/arm/include/asm/arch-davinci/, in
which case you can use #include <asm/arch/...>

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
On a clear disk you can seek forever.