public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Move and rename common headers from under	board/davinci
Date: Fri, 22 Oct 2010 13:34:34 +0530	[thread overview]
Message-ID: <20101022080434.GC8597@Hardy> (raw)
In-Reply-To: <20101022075601.09379136320@gemini.denx.de>

hi Wolfgang,

On Fri Oct 22, 2010 at 09:56:01AM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
> 
> In message <20101022072634.GA8597@Hardy> you wrote:
> >
> > > > This patch is needed for adding board support for the hawkboard which
> > > > uses nand_spl based boot mechanism.
> > > 
> > > Why would that be the case?
> > 
> >   The board file is symlinked under the nand_spl/board directory and
> >   we cannot do relative path based file inclusion.
> 
> Which points out where the actual problem comes from: relative path
> based file inclusion is a Bad Thing and should be avoided.

  So then can we remove the relative path based inclusion used by all
  files under board/davinci. We would need to add corresponding path
  entries to the board's config.mk.

> > > If these headers are indeed common to all davinci boards, they should
> > > probably be moved to arch/arm/cpu/arm926ejs/davinci/
> > 
> >   Ok. In that case, i guess i can keep them in the same place. Would
> >   rename them as davinci_misc.h and da8xx_common.h, and add the
> >   include path in my board's config.mk. Is this fine.
> 
> I don't understand what you man by "keep them in the same place".
> Where?

  I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
  keep them in their current location under board/davinci.
  
-sughosh

  reply	other threads:[~2010-10-22  8:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 19:42 [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci Sughosh Ganu
2010-10-21 20:30 ` Wolfgang Denk
2010-10-22  7:26   ` Sughosh Ganu
2010-10-22  7:56     ` Wolfgang Denk
2010-10-22  8:04       ` Sughosh Ganu [this message]
2010-10-22  8:26         ` Wolfgang Denk
2010-10-22  8:46           ` Sughosh Ganu
2010-10-22  9:47             ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101022080434.GC8597@Hardy \
    --to=urwithsughosh@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox