From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sughosh Ganu Date: Fri, 22 Oct 2010 13:34:34 +0530 Subject: [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci In-Reply-To: <20101022075601.09379136320@gemini.denx.de> References: <1287690158-6055-1-git-send-email-urwithsughosh@gmail.com> <20101021203009.3FDEC1359B7@gemini.denx.de> <20101022072634.GA8597@Hardy> <20101022075601.09379136320@gemini.denx.de> Message-ID: <20101022080434.GC8597@Hardy> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de hi Wolfgang, On Fri Oct 22, 2010 at 09:56:01AM +0200, Wolfgang Denk wrote: > Dear Sughosh Ganu, > > In message <20101022072634.GA8597@Hardy> you wrote: > > > > > > This patch is needed for adding board support for the hawkboard which > > > > uses nand_spl based boot mechanism. > > > > > > Why would that be the case? > > > > The board file is symlinked under the nand_spl/board directory and > > we cannot do relative path based file inclusion. > > Which points out where the actual problem comes from: relative path > based file inclusion is a Bad Thing and should be avoided. So then can we remove the relative path based inclusion used by all files under board/davinci. We would need to add corresponding path entries to the board's config.mk. > > > If these headers are indeed common to all davinci boards, they should > > > probably be moved to arch/arm/cpu/arm926ejs/davinci/ > > > > Ok. In that case, i guess i can keep them in the same place. Would > > rename them as davinci_misc.h and da8xx_common.h, and add the > > include path in my board's config.mk. Is this fine. > > I don't understand what you man by "keep them in the same place". > Where? I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and keep them in their current location under board/davinci. -sughosh