From: Sughosh Ganu <urwithsughosh@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci
Date: Fri, 22 Oct 2010 14:16:41 +0530 [thread overview]
Message-ID: <20101022084641.GD8597@Hardy> (raw)
In-Reply-To: <20101022082608.7D3C11359B3@gemini.denx.de>
hi Wolfgang,
On Fri Oct 22, 2010 at 10:26:08AM +0200, Wolfgang Denk wrote:
> Dear Sughosh Ganu,
>
> In message <20101022080434.GC8597@Hardy> you wrote:
> >
> > > Which points out where the actual problem comes from: relative path
> > > based file inclusion is a Bad Thing and should be avoided.
> >
> > So then can we remove the relative path based inclusion used by all
> > files under board/davinci. We would need to add corresponding path
> > entries to the board's config.mk.
>
> Please don't. Assume that all config.mk files are candidates for
> removal.
>
> Rather put commonly used header files in places where they can be
> found easily.
Which is what i was trying in the first place :). Any place other
than the include directory would need us to specifiy the path to the
files. Where can we put such information then, if not
config.mk. Please let me know.
> > > I don't understand what you man by "keep them in the same place".
> > > Where?
> >
> > I meant not moving the files to arch/arm/cpu/arm926ejs/davinci, and
> > keep them in their current location under board/davinci.
>
> That does not solve the problem, then, it seems.
Yes, in case we do not move it to the standard include path, i don't
think we are adding any value by moving it under the arch
directory. Please let me know how to proceed on this.
-sughosh
next prev parent reply other threads:[~2010-10-22 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-21 19:42 [U-Boot] [PATCH 1/2] Move and rename common headers from under board/davinci Sughosh Ganu
2010-10-21 20:30 ` Wolfgang Denk
2010-10-22 7:26 ` Sughosh Ganu
2010-10-22 7:56 ` Wolfgang Denk
2010-10-22 8:04 ` Sughosh Ganu
2010-10-22 8:26 ` Wolfgang Denk
2010-10-22 8:46 ` Sughosh Ganu [this message]
2010-10-22 9:47 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022084641.GD8597@Hardy \
--to=urwithsughosh@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox