From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wolfgang Denk <wd@denx.de>
Date: Fri, 22 Oct 2010 11:31:21 +0200
Subject: [U-Boot] [PATCH 1/1] net:Fix potential empty DHCP Parameter
	Request List
In-Reply-To: <1287736585-32489-1-git-send-email-r64343@freescale.com>
References: <1287736585-32489-1-git-send-email-r64343@freescale.com>
Message-ID: <20101022093121.BD6D21359B3@gemini.denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Jason Liu,

In message <1287736585-32489-1-git-send-email-r64343@freescale.com> you wrote:
> From: Gray Remlin <g_remlin@rocketmail.com>
> 
> Can't get IP address with dhcp due to the dhcp server not
> allow the empty param list request under some network env
> 
> Signed-off-by: Gray Remlin <g_remlin@rocketmail.com>
> Signed-off-by: Jason Liu <r64343@freescale.com>
> ---
>  net/bootp.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)

What is the purpose of you reposting Gray's patch here, without any
comment?

Did you change it?  Did you test it? Or what??

You did not even keep the mail thread in place; please do not do that!

Please make sure to read
http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions


In
http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/86974/focus=86995
I asked you to test Gray's; you did not send a formal "Tested-by:"
notification, but ok.


But I really don't understand why you now repost this patch,
completely without any explanations?  Please elucidate.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The inappropriate cannot be beautiful.
             - Frank Lloyd Wright _The Future of Architecture_ (1953)