From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Date: Fri, 22 Oct 2010 12:34:48 +0200
Subject: [U-Boot] [Patch v3] Add support for HP Jornada flashrom boards
In-Reply-To: <20101019214529.9AEFE136320@gemini.denx.de>
References: <1287178303-17003-1-git-send-email-kristoffer.ericson@gmail.com>
	<20101019214529.9AEFE136320@gemini.denx.de>
Message-ID: <20101022103448.GE994@boggieman>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Tue, Oct 19, 2010 at 11:45:29PM +0200, Wolfgang Denk wrote:
> Dear Kristoffer Ericson,
> 
> In message <1287178303-17003-1-git-send-email-kristoffer.ericson@gmail.com> you wrote:
> > This patch adds support for the HP Jornada flashboards
> > that were made in 2008. Older flashroms should work if
> > memory registers are adjusted.
> > 
> > Signed-off-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> > ---
> > Changes for v2:
> > 	- Adding myself to MAINTAINERS
> > 	- Fixing line lengths
> > 	- Fixing comment style
> > Changes for v3:
> > 	- setting MACH_TYPE_JORNADA720
> > 	- CONFIG_SYS_HZ = 1000
> > 
> >  MAINTAINERS               |    4 +
> >  board/jornada/Makefile    |   53 +++++++++++
> >  board/jornada/config.mk   |    6 ++
> >  board/jornada/jornada.c   |   65 ++++++++++++++
> >  board/jornada/setup.S     |  210 +++++++++++++++++++++++++++++++++++++++++++++
> >  board/jornada/u-boot.lds  |   58 +++++++++++++
> >  boards.cfg                |    1 +
> >  include/configs/jornada.h |  153 +++++++++++++++++++++++++++++++++
> >  8 files changed, 550 insertions(+), 0 deletions(-)
> >  create mode 100644 board/jornada/Makefile
> >  create mode 100644 board/jornada/config.mk
> >  create mode 100644 board/jornada/jornada.c
> >  create mode 100644 board/jornada/setup.S
> >  create mode 100644 board/jornada/u-boot.lds
> >  create mode 100644 include/configs/jornada.h
> 
> Applied, with some modifications:

Thanks, sounds like resonable changes. I believe I
had something in jornada_init() earlier but moved it.
> 
> Adpted for TEXT_BASE -> CONFIG_SYS_TEXT_BASE rename.
> Removed now redundant board/jornada/config.mk file.
> Removed unused empty jornada_init() function to silence
> "jornada.c:35: warning: 'jornada_init' defined but not used"
> 
> Please check everything is OK for you.
> 
> Best regards,
> 
> Wolfgang Denk
> 
> -- 
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> miracle:  an  extremely  outstanding  or  unusual  event,  thing,  or
> accomplishment.                                - Webster's Dictionary