From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 26 Oct 2010 17:22:58 +0200
Subject: [U-Boot] [PATCH 3/3] Replace CONFIG_SYS_GBL_DATA_SIZE by
	auto-generated value
In-Reply-To: <20101026144107.58E851365DB@gemini.denx.de>
References: <1288101601-24871-1-git-send-email-wd@denx.de>
	<201010261622.57768.sr@denx.de>
	<20101026144107.58E851365DB@gemini.denx.de>
Message-ID: <201010261722.58861.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Tuesday 26 October 2010 16:41:07 Wolfgang Denk wrote:
> You are right, especially as the resulting start address of the global
> data is usually also used as the top of the internal stack. Guess we
> should align it on 16 bytes, to be sure.

Yes, we already had this 8-byte stack align problem on ARM, IIRC.
 
> BTW - this uncovers a number of other problems.
> 
> commit 800eb096 "POST cleanup." inserts a single data word between
> global data and initial stack, thus also breaking stack alignment.
> 
> I think this approach is wrong, the POST word should be made part of
> the global_data instead.

Good idea.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de