From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alessandro Rubini <rubini-list@gnudd.com>
Date: Tue, 26 Oct 2010 22:57:56 +0200
Subject: [U-Boot] [PATCH 3/3 v2] Replace CONFIG_SYS_GBL_DATA_SIZE by
 auto-generated value
In-Reply-To: <20101026203811.D0EF1152451@gemini.denx.de>
References: <20101026203811.D0EF1152451@gemini.denx.de>
	<1288104730-25651-1-git-send-email-wd@denx.de>
	<1288101601-24871-4-git-send-email-wd@denx.de>
	<20101026195429.GA1349@morgana.i.gnudd.com>
Message-ID: <20101026205756.GA2139@morgana.i.gnudd.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

>> This has already been applied, sooner than usual.  Isn't it cleaner to
>> force alignment on the structure itself? This way different architectures
>> may use different values, if the need arises.
> 
> It would be better, but how to implement that?

Instead of:

     DEFINE(GENERATED_GBL_DATA_SIZE,
             (sizeof(struct global_data)+15) & ~15);

I'd use:

     DEFINE(GENERATED_GBL_DATA_SIZE,
             (sizeof(struct global_data)),

leaving the alignment requirement in the structure itself
(include/asm/global_data.h for each architecture).

/alessandro