[U-Boot] [PATCH 3/3 V3] Add board support for hawkboard

Scott Wood
2010-10-28T18:32:26Z

On Thu, 28 Oct 2010 23:59:10 +0530
sughosh ganu <urwithsughosh@gmail.com> wrote:

> hi Scott,
>
> On Thu, Oct 28, 2010 at 11:23 PM, Scott Wood <scottwood@freescale.com>wrote:
>
> > On Tue, 26 Oct 2010 23:28:05 +0530
> > Sughosh Ganu <urwithsughosh@gmail.com> wrote:
> >
> > > diff --git a/drivers/mtd/nand/davinci_nand.c
> > b/drivers/mtd/nand/davinci_nand.c
> > > index d41579c..ad70dd9 100644
> > > --- a/drivers/mtd/nand/davinci_nand.c
> > > +++ b/drivers/mtd/nand/davinci_nand.c
> > > @@ -635,6 +635,7 @@ void davinci_nand_init(struct nand_chip *nand)
> > > nand->write_buf = nand_davinci_write_buf;
> > >
> > > nand->dev_ready = nand_davinci_dev_ready;
> > > + nand->select_chip = NULL;
> >
> > Shouldn't it already be NULL from the BSS?
> >
> > There are many other fields where this is relied on...
> >
> >
> This is needed when building for nand_spl, where the nand_boot function in
> nand_boot.c declares the chip object as a local variable.

Ah. In that case nand_boot() should probably clear select_chip before
calling board_nand_init().

-Scott