From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] Are typedefs discouraged?
Date: Sun, 31 Oct 2010 10:28:29 +0100 [thread overview]
Message-ID: <20101031092829.0F6871522C0@gemini.denx.de> (raw)
In-Reply-To: <4CCD305D.50600@emk-elektronik.de>
Dear Reinhard Meyer,
In message <4CCD305D.50600@emk-elektronik.de> you wrote:
> Hi All,
>
> WARNING: do not add new typedefs
> #64: FILE: arch/arm/include/asm/arch-at91/at91_shdwn.h:19:
> +typedef struct at91_shdwn {
>
> total: 0 errors, 1 warnings, 45 lines checked
>
> xx has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> I assume that "rule" does not apply to u-boot, and such warnings
> can be ignored?
No.
> However why would typedefs be discouraged in kernel?
Please read "Chapter 5: Typedefs" in the "CodingStyle" document.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There's a way out of any cage.
-- Captain Christopher Pike, "The Menagerie" ("The Cage"),
stardate unknown.
next prev parent reply other threads:[~2010-10-31 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 9:01 [U-Boot] Are typedefs discouraged? Reinhard Meyer
2010-10-31 9:28 ` Wolfgang Denk [this message]
2010-10-31 9:45 ` Reinhard Meyer
2010-10-31 10:36 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101031092829.0F6871522C0@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox