From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] UBIFS: Change ubifsload to not read beyond the requested size
Date: Mon, 1 Nov 2010 14:06:57 +0100 [thread overview]
Message-ID: <201011011406.57956.sr@denx.de> (raw)
In-Reply-To: <20101029205404.71F62BB0AD@gemini.denx.de>
Hi Wolfgang,
On Friday 29 October 2010 22:54:04 Wolfgang Denk wrote:
> > + buff = malloc(UBIFS_BLOCK_SIZE);
> > +
> > + /* Read block-siez into temp buffer */
> > + ret = read_block(inode, buff, block, dn);
> > + if (last_block_size)
> > + dlen = last_block_size;
> > + else
> > + dlen = le32_to_cpu(dn->size);
>
> How about some error handling?
>
> malloc() can fail, and read_block() can fail as well.
Right. I'll change this and send an updated version.
Thanks for the review.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
prev parent reply other threads:[~2010-11-01 13:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 9:04 [U-Boot] [PATCH] UBIFS: Change ubifsload to not read beyond the requested size Stefan Roese
2010-10-29 14:01 ` Ben Gardiner
2010-11-01 15:47 ` Stefan Roese
2010-10-29 20:54 ` Wolfgang Denk
2010-11-01 13:06 ` Stefan Roese [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201011011406.57956.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox